From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-mm@kvack.org, rientjes@google.com, oleg@redhat.com,
vdavydov@parallels.com, akpm@linux-foundation.org
Subject: Re: [PATCH 07/10] mm, oom: fortify task_will_free_mem
Date: Fri, 3 Jun 2016 14:12:09 +0200 [thread overview]
Message-ID: <20160603121209.GF20676@dhcp22.suse.cz> (raw)
In-Reply-To: <201606032042.ADC04699.SFFOJLHFOOQMVt@I-love.SAKURA.ne.jp>
On Fri 03-06-16 20:42:24, Tetsuo Handa wrote:
> Michal Hocko wrote:
> > +static inline bool __task_will_free_mem(struct task_struct *task)
> > +{
> > + struct signal_struct *sig = task->signal;
> > +
> > + /*
> > + * A coredumping process may sleep for an extended period in exit_mm(),
> > + * so the oom killer cannot assume that the process will promptly exit
> > + * and release memory.
> > + */
> > + if (sig->flags & SIGNAL_GROUP_COREDUMP)
> > + return false;
> > +
> > + if (sig->flags & SIGNAL_GROUP_EXIT)
> > + return true;
> > +
> > + if (thread_group_empty(task) && PF_EXITING)
> > + return true;
>
> "thread_group_empty(task) && PF_EXITING" is wrong.
Sigh. I've screwed during the rebase again. Sorry about that!
---
next prev parent reply other threads:[~2016-06-03 12:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 9:16 [PATCH 0/10 -v3] Handle oom bypass more gracefully Michal Hocko
2016-06-03 9:16 ` [PATCH 01/10] proc, oom: drop bogus task_lock and mm check Michal Hocko
2016-06-03 9:16 ` [PATCH 02/10] proc, oom: drop bogus sighand lock Michal Hocko
2016-06-03 9:16 ` [PATCH 03/10] proc, oom_adj: extract oom_score_adj setting into a helper Michal Hocko
2016-06-03 9:16 ` [PATCH 04/10] mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj Michal Hocko
2016-06-03 9:16 ` [PATCH 05/10] mm, oom: skip vforked tasks from being selected Michal Hocko
2016-06-03 9:16 ` [PATCH 06/10] mm, oom: kill all tasks sharing the mm Michal Hocko
2016-06-06 22:27 ` David Rientjes
2016-06-06 23:20 ` Oleg Nesterov
2016-06-07 6:37 ` Michal Hocko
2016-06-07 22:15 ` David Rientjes
2016-06-08 6:22 ` Michal Hocko
2016-06-08 22:51 ` David Rientjes
2016-06-09 6:46 ` Michal Hocko
2016-06-03 9:16 ` [PATCH 07/10] mm, oom: fortify task_will_free_mem Michal Hocko
2016-06-03 11:42 ` Tetsuo Handa
2016-06-03 12:12 ` Michal Hocko [this message]
2016-06-03 9:16 ` [PATCH 08/10] mm, oom: task_will_free_mem should skip oom_reaped tasks Michal Hocko
2016-06-03 9:16 ` [RFC PATCH 09/10] mm, oom_reaper: do not attempt to reap a task more than twice Michal Hocko
2016-06-03 9:16 ` [RFC PATCH 10/10] mm, oom: hide mm which is shared with kthread or global init Michal Hocko
2016-06-03 15:16 ` Tetsuo Handa
2016-06-06 8:15 ` Michal Hocko
2016-06-06 13:26 ` Michal Hocko
2016-06-07 6:26 ` Michal Hocko
2016-06-03 12:00 ` [PATCH 0/10 -v3] Handle oom bypass more gracefully Tetsuo Handa
2016-06-03 12:20 ` Michal Hocko
2016-06-03 12:22 ` Michal Hocko
2016-06-04 10:57 ` Tetsuo Handa
2016-06-06 8:39 ` Michal Hocko
2016-06-03 15:17 ` Tetsuo Handa
2016-06-06 8:36 ` Michal Hocko
2016-06-07 14:30 ` Tetsuo Handa
2016-06-07 15:05 ` Michal Hocko
2016-06-07 21:49 ` Tetsuo Handa
2016-06-08 7:27 ` Michal Hocko
2016-06-08 14:55 ` Tetsuo Handa
2016-06-08 16:05 ` Michal Hocko
2016-06-09 11:52 [PATCH 0/10 -v4] " Michal Hocko
2016-06-09 11:52 ` [PATCH 07/10] mm, oom: fortify task_will_free_mem Michal Hocko
2016-06-09 13:18 ` Tetsuo Handa
2016-06-09 14:20 ` Michal Hocko
2016-06-11 8:10 ` Tetsuo Handa
2016-06-13 11:27 ` Michal Hocko
2016-06-16 12:54 ` Tetsuo Handa
2016-06-16 14:29 ` Michal Hocko
2016-06-16 15:40 ` Tetsuo Handa
2016-06-16 15:53 ` Michal Hocko
2016-06-17 11:38 ` Tetsuo Handa
2016-06-17 12:26 ` Michal Hocko
2016-06-17 13:12 ` Tetsuo Handa
2016-06-17 13:29 ` Michal Hocko
2016-06-20 12:43 [PATCH 0/10 -v5] Handle oom bypass more gracefully Michal Hocko
2016-06-20 12:43 ` [PATCH 07/10] mm, oom: fortify task_will_free_mem Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603121209.GF20676@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox