From: Michal Hocko <mhocko@kernel.org>
To: Geliang Tang <geliangtang@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Christoph Lameter <cl@linux.com>,
Mel Gorman <mgorman@techsingularity.net>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h
Date: Thu, 2 Jun 2016 08:44:29 +0200 [thread overview]
Message-ID: <20160602064428.GE1995@dhcp22.suse.cz> (raw)
In-Reply-To: <866efd744a89b6e16c9d3acd1a00b011adbd59af.1464847139.git.geliangtang@gmail.com>
On Thu 02-06-16 14:15:35, Geliang Tang wrote:
> Remove unused header cpumask.h from mm/vmstat.c.
what about for_each_online_cpu? Maybe it will get included transitively
from other header but I guess it is better to have a direct include
because transitive includes lead to unexpected compilation issues.
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> mm/vmstat.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 1b585f8..3653449 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -15,7 +15,6 @@
> #include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/cpu.h>
> -#include <linux/cpumask.h>
> #include <linux/vmstat.h>
> #include <linux/proc_fs.h>
> #include <linux/seq_file.h>
> --
> 1.9.1
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-06-02 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 6:15 [PATCH 1/4] mm/init-mm: " Geliang Tang
2016-06-02 6:15 ` [PATCH 2/4] mm: kmemleak: " Geliang Tang
2016-06-02 6:15 ` [PATCH 3/4] mm/vmstat: " Geliang Tang
2016-06-02 6:15 ` [PATCH 4/4] mm/zsmalloc: " Geliang Tang
2016-06-02 7:10 ` Sergey Senozhatsky
2016-06-02 6:44 ` Michal Hocko [this message]
2016-06-02 13:46 ` [PATCH 3/4] mm/vmstat: " Christoph Lameter
2016-06-02 9:32 ` [PATCH 2/4] mm: kmemleak: " Catalin Marinas
2016-06-02 10:10 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602064428.GE1995@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=geliangtang@gmail.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox