From: Minchan Kim <minchan@kernel.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Hugh Dickins <hughd@google.com>,
"Kirill A.Shutemov" <kirill.shutemov@linux.intel.com>,
Andi Kleen <andi@firstfloor.org>, Aaron Lu <aaron.lu@intel.com>,
Huang Ying <ying.huang@intel.com>, linux-mm <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Cleanup - Reorganize the shrink_page_list code into smaller functions
Date: Tue, 31 May 2016 18:15:50 +0900 [thread overview]
Message-ID: <20160531091550.GA19976@bbox> (raw)
In-Reply-To: <1463779979.22178.142.camel@linux.intel.com>
On Fri, May 20, 2016 at 02:32:59PM -0700, Tim Chen wrote:
> This patch consolidates the page out and the various cleanup operations
> within shrink_page_list function into handle_pgout and pg_finish
> functions.
>
> This makes the shrink_page_list function more concise and allows for
> the separation of page out and page scan operations.
> It paves the way to group similar pages together and batch
> process them in the page out path for better efficiency.
>
> After we have scanned a page in shrink_page_list and
> completed paging, the final disposition and clean
> up of the page is consolidated into pg_finish. T
> he designated disposition of the page from page scanning
> in shrink_page_list is marked with one of the designation in pg_result.
>
> There is no intention to change shrink_page_list's
> functionality or logic in this patch.
>
> Thanks.
>
> Tim
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
Hello Tim,
checking file mm/vmscan.c
patch: **** malformed patch at line 89: mapping->a_ops->is_dirty_writeback(page, dirty, writeback);
Could you resend formal patch?
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-31 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 21:32 Tim Chen
2016-05-31 9:15 ` Minchan Kim [this message]
2016-05-31 17:17 ` Tim Chen
2016-06-01 7:12 ` Minchan Kim
2016-06-01 18:23 ` Tim Chen
2016-06-07 8:21 ` Minchan Kim
2016-06-07 20:43 ` Tim Chen
2016-06-09 4:40 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531091550.GA19976@bbox \
--to=minchan@kernel.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tim.c.chen@linux.intel.com \
--cc=vdavydov@virtuozzo.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox