From: Michal Hocko <mhocko@kernel.org>
To: yoma sophian <sophian.yoma@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: page order 0 allocation fail but free pages are enough
Date: Wed, 25 May 2016 08:31:12 +0200 [thread overview]
Message-ID: <20160525063112.GA20132@dhcp22.suse.cz> (raw)
In-Reply-To: <CADUS3okn3a74j-aYKyfPis+NJa4OGvNPsJWW4iyyRu6bfdZB6Q@mail.gmail.com>
On Wed 25-05-16 10:11:23, yoma sophian wrote:
> >> free-free_cma = 636kB so you are way below the watermark and that is
> > After tracing the __alloc_pages_slowpath, in the 2nd time we call
> > get_page_from_freelist, we will purposely put alloc_flags &
> > ~ALLOC_NO_WATERMARKS.
> > Doesn't that mean kernel will bypass __zone_watermark_ok?
> I apologize for my misunderstanding.
> (alloc_flags & ~ALLOC_NO_WATERMARKS) will NOT bypass __zone_watermark_ok.
> on the contrary, it will filter out watermarks checking.
true
> there is one thing makes me curious,
> why we put alloc_flags = gfp_to_alloc_flags(gfp_mask) in
> __alloc_pages_slowpath instead of __alloc_pages_nodemask?
Because we want to make the hot path as effective as possible. So the
hot path is an optimistic attempt with low watermark target which then
falls into the slow path with the full gfp_masks restrictions against
min watermark.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-25 6:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 6:47 yoma sophian
2016-05-23 14:47 ` Michal Hocko
2016-05-23 15:31 ` yoma sophian
2016-05-23 19:00 ` Michal Hocko
2016-05-24 11:40 ` yoma sophian
2016-05-24 11:50 ` Michal Hocko
2016-05-24 15:06 ` yoma sophian
2016-05-25 2:11 ` yoma sophian
2016-05-25 6:31 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525063112.GA20132@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=linux-mm@kvack.org \
--cc=sophian.yoma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox