From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] af_unix: charge buffers to kmemcg
Date: Tue, 24 May 2016 10:41:56 +0300 [thread overview]
Message-ID: <20160524074156.GG7917@esperanza> (raw)
In-Reply-To: <ba7e91e4f7aaea4e4d3b4ce60bf8bb2a3eceba0a.1463997354.git.vdavydov@virtuozzo.com>
[adding netdev to Cc]
On Mon, May 23, 2016 at 01:20:29PM +0300, Vladimir Davydov wrote:
> Unix sockets can consume a significant amount of system memory, hence
> they should be accounted to kmemcg.
>
> Since unix socket buffers are always allocated from process context,
> all we need to do to charge them to kmemcg is set __GFP_ACCOUNT in
> sock->sk_allocation mask.
>
> Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> ---
> net/unix/af_unix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 80aa6a3e6817..022bdd3ab7d9 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -769,6 +769,7 @@ static struct sock *unix_create1(struct net *net, struct socket *sock, int kern)
> lockdep_set_class(&sk->sk_receive_queue.lock,
> &af_unix_sk_receive_queue_lock_key);
>
> + sk->sk_allocation = GFP_KERNEL_ACCOUNT;
> sk->sk_write_space = unix_write_space;
> sk->sk_max_ack_backlog = net->unx.sysctl_max_dgram_qlen;
> sk->sk_destruct = unix_sock_destructor;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-24 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 10:20 [PATCH 0/8] More stuff to charge " Vladimir Davydov
2016-05-23 10:20 ` [PATCH 1/8] mm: remove pointless struct in struct page definition Vladimir Davydov
2016-05-23 10:20 ` [PATCH 2/8] mm: clean up non-standard page->_mapcount users Vladimir Davydov
2016-05-23 10:20 ` [PATCH 3/8] mm: memcontrol: cleanup kmem charge functions Vladimir Davydov
2016-05-23 10:20 ` [PATCH 4/8] mm: charge/uncharge kmemcg from generic page allocator paths Vladimir Davydov
2016-05-23 10:20 ` [PATCH 5/8] mm: memcontrol: teach uncharge_list to deal with kmem pages Vladimir Davydov
2016-05-23 10:20 ` [PATCH 6/8] arch: x86: charge page tables to kmemcg Vladimir Davydov
2016-05-23 10:20 ` [PATCH 7/8] pipe: account " Vladimir Davydov
2016-05-23 10:39 ` kbuild test robot
2016-05-23 10:57 ` Vladimir Davydov
2016-05-23 11:57 ` Vladimir Davydov
2016-05-23 11:50 ` kbuild test robot
2016-05-23 11:52 ` kbuild test robot
2016-05-23 10:20 ` [PATCH 8/8] af_unix: charge buffers " Vladimir Davydov
2016-05-23 22:13 ` David Miller
2016-05-24 7:41 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524074156.GG7917@esperanza \
--to=vdavydov@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox