From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] pipe: account to kmemcg
Date: Mon, 23 May 2016 13:57:18 +0300 [thread overview]
Message-ID: <20160523105718.GC7917@esperanza> (raw)
In-Reply-To: <201605231850.3CoT8OXo%fengguang.wu@intel.com>
On Mon, May 23, 2016 at 06:39:40PM +0800, kbuild test robot wrote:
...
> fs/built-in.o: In function `anon_pipe_buf_steal':
> >> pipe.c:(.text+0x5f8d): undefined reference to `memcg_kmem_uncharge'
From: Vladimir Davydov <vdavydov@virtuozzo.com>
Subject: [PATCH] pipe-account-to-kmemcg-fix
diff --git a/fs/pipe.c b/fs/pipe.c
index 6345f3543788..b3ad0b33f04e 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -144,8 +144,10 @@ static int anon_pipe_buf_steal(struct pipe_inode_info *pipe,
struct page *page = buf->page;
if (page_count(page) == 1) {
- memcg_kmem_uncharge(page, 0);
- __ClearPageKmemcg(page);
+ if (memcg_kmem_enabled()) {
+ memcg_kmem_uncharge(page, 0);
+ __ClearPageKmemcg(page);
+ }
__SetPageLocked(page);
return 0;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-23 10:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 10:20 [PATCH 0/8] More stuff to charge " Vladimir Davydov
2016-05-23 10:20 ` [PATCH 1/8] mm: remove pointless struct in struct page definition Vladimir Davydov
2016-05-23 10:20 ` [PATCH 2/8] mm: clean up non-standard page->_mapcount users Vladimir Davydov
2016-05-23 10:20 ` [PATCH 3/8] mm: memcontrol: cleanup kmem charge functions Vladimir Davydov
2016-05-23 10:20 ` [PATCH 4/8] mm: charge/uncharge kmemcg from generic page allocator paths Vladimir Davydov
2016-05-23 10:20 ` [PATCH 5/8] mm: memcontrol: teach uncharge_list to deal with kmem pages Vladimir Davydov
2016-05-23 10:20 ` [PATCH 6/8] arch: x86: charge page tables to kmemcg Vladimir Davydov
2016-05-23 10:20 ` [PATCH 7/8] pipe: account " Vladimir Davydov
2016-05-23 10:39 ` kbuild test robot
2016-05-23 10:57 ` Vladimir Davydov [this message]
2016-05-23 11:57 ` Vladimir Davydov
2016-05-23 11:50 ` kbuild test robot
2016-05-23 11:52 ` kbuild test robot
2016-05-23 10:20 ` [PATCH 8/8] af_unix: charge buffers " Vladimir Davydov
2016-05-23 22:13 ` David Miller
2016-05-24 7:41 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523105718.GC7917@esperanza \
--to=vdavydov@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox