From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by kanga.kvack.org (Postfix) with ESMTP id 87DDA6B0260 for ; Fri, 20 May 2016 09:16:52 -0400 (EDT) Received: by mail-lb0-f198.google.com with SMTP id i9so3802937lbc.3 for ; Fri, 20 May 2016 06:16:52 -0700 (PDT) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com. [74.125.82.66]) by mx.google.com with ESMTPS id t203si6789657wmg.31.2016.05.20.06.16.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 May 2016 06:16:51 -0700 (PDT) Received: by mail-wm0-f66.google.com with SMTP id n129so29154575wmn.1 for ; Fri, 20 May 2016 06:16:51 -0700 (PDT) Date: Fri, 20 May 2016 15:16:49 +0200 From: Michal Hocko Subject: Re: [v2 PATCH] mm: move page_ext_init after all struct pages are initialized Message-ID: <20160520131649.GC5197@dhcp22.suse.cz> References: <1463696006-31360-1-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463696006-31360-1-git-send-email-yang.shi@linaro.org> Sender: owner-linux-mm@kvack.org List-ID: To: Yang Shi Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org On Thu 19-05-16 15:13:26, Yang Shi wrote: [...] > diff --git a/init/main.c b/init/main.c > index b3c6e36..2075faf 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -606,7 +606,6 @@ asmlinkage __visible void __init start_kernel(void) > initrd_start = 0; > } > #endif > - page_ext_init(); > debug_objects_mem_init(); > kmemleak_init(); > setup_per_cpu_pageset(); > @@ -1004,6 +1003,8 @@ static noinline void __init kernel_init_freeable(void) > sched_init_smp(); > > page_alloc_init_late(); > + /* Initialize page ext after all struct pages are initializaed */ > + page_ext_init(); > > do_basic_setup(); I might be missing something but don't we have the same problem with CONFIG_FLATMEM? page_ext_init_flatmem is called way earlier. Or CONFIG_DEFERRED_STRUCT_PAGE_INIT is never enabled for CONFIG_FLATMEM? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org