From: Peter Zijlstra <peterz@infradead.org>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
Cc: cl@linux.com, tj@kernel.org, mika.j.penttila@gmail.com,
mingo@redhat.com, akpm@linux-foundation.org, rjw@rjwysocki.net,
hpa@zytor.com, yasu.isimatu@gmail.com,
isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
izumi.taku@jp.fujitsu.com, gongzhaogang@inspur.com,
len.brown@intel.com, lenb@kernel.org, tglx@linutronix.de,
chen.tang@easystack.cn, rafael@kernel.org, x86@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v7 0/5] Make cpuid <-> nodeid mapping persistent
Date: Thu, 19 May 2016 16:46:57 +0200 [thread overview]
Message-ID: <20160519144657.GK3206@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <cover.1463652944.git.zhugh.fnst@cn.fujitsu.com>
On Thu, May 19, 2016 at 06:39:41PM +0800, Zhu Guihua wrote:
> [Problem]
>
> cpuid <-> nodeid mapping is firstly established at boot time. And workqueue caches
> the mapping in wq_numa_possible_cpumask in wq_numa_init() at boot time.
>
> When doing node online/offline, cpuid <-> nodeid mapping is established/destroyed,
> which means, cpuid <-> nodeid mapping will change if node hotplug happens. But
> workqueue does not update wq_numa_possible_cpumask.
So why are you not fixing up wq_numa_possible_cpumask instead? That
seems the far easier solution.
Do all the other archs that support NUMA and HOTPLUG have the mapping
stable, or will you now go fix each and every one of them?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-19 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 10:39 Zhu Guihua
2016-05-19 10:39 ` [PATCH v7 1/5] x86, memhp, numa: Online memory-less nodes at boot time Zhu Guihua
2016-05-19 10:40 ` [PATCH v7 2/5] x86, acpi, cpu-hotplug: Enable acpi to register all possible cpus " Zhu Guihua
2016-05-19 10:40 ` [PATCH v7 3/5] x86, acpi, cpu-hotplug: Introduce cpuid_to_apicid[] array to store persistent cpuid <-> apicid mapping Zhu Guihua
2016-05-19 10:40 ` [PATCH v7 4/5] x86, acpi, cpu-hotplug: Enable MADT APIs to return disabled apicid Zhu Guihua
2016-05-19 10:40 ` [PATCH v7 5/5] x86, acpi, cpu-hotplug: Set persistent cpuid <-> nodeid mapping when booting Zhu Guihua
2016-05-19 10:41 ` [PATCH v7 0/5] Make cpuid <-> nodeid mapping persistent Zhu Guihua
2016-05-19 12:58 ` Rafael J. Wysocki
2016-05-19 14:46 ` Peter Zijlstra [this message]
2016-05-23 7:02 ` Zhu Guihua
2016-05-25 20:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519144657.GK3206@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chen.tang@easystack.cn \
--cc=cl@linux.com \
--cc=gongzhaogang@inspur.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mika.j.penttila@gmail.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox