From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by kanga.kvack.org (Postfix) with ESMTP id 5E6E36B025E for ; Mon, 16 May 2016 18:36:58 -0400 (EDT) Received: by mail-pa0-f72.google.com with SMTP id gw7so272730310pac.0 for ; Mon, 16 May 2016 15:36:58 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id c140si48583880pfb.198.2016.05.16.15.36.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 May 2016 15:36:57 -0700 (PDT) Date: Mon, 16 May 2016 15:36:56 -0700 From: Andrew Morton Subject: Re: [PATCH] mm: unhide vmstat_text definition for CONFIG_SMP Message-Id: <20160516153656.2cf37a2f4af4b30cee6a7c86@linux-foundation.org> In-Reply-To: <20160516142332.GL23146@dhcp22.suse.cz> References: <1462978517-2972312-1-git-send-email-arnd@arndb.de> <20160516142332.GL23146@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Arnd Bergmann , Hugh Dickins , Vlastimil Babka , Christoph Lameter , Mel Gorman , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, 16 May 2016 16:23:33 +0200 Michal Hocko wrote: > Andrew, I think that the following is more straightforward fix and > should be folded in to the patch which has introduced vmstat_refresh. > --- > >From b8dd18fb7df040e1bfe61aadde1d903589de15e4 Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Mon, 16 May 2016 16:19:53 +0200 > Subject: [PATCH] mmotm: mm-proc-sys-vm-stat_refresh-to-force-vmstat-update-fix > > Arnd has reported: > In randconfig builds with sysfs, procfs and numa all disabled, > but SMP enabled, we now get a link error in the newly introduced > vmstat_refresh function: > > mm/built-in.o: In function `vmstat_refresh': > :(.text+0x15c78): undefined reference to `vmstat_text' > > vmstat_refresh is proc_fs specific so there is no reason to define it > when !CONFIG_PROC_FS. I already had this: From: Christoph Lameter Subject: Do not build vmstat_refresh if there is no procfs support It makes no sense to build functionality into the kernel that cannot be used and causes build issues. Link: http://lkml.kernel.org/r/alpine.DEB.2.20.1605111011260.9351@east.gentwo.org Signed-off-by: Christoph Lameter Reported-by: Arnd Bergmann Signed-off-by: Andrew Morton --- mm/vmstat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -puN mm/vmstat.c~mm-proc-sys-vm-stat_refresh-to-force-vmstat-update-fix mm/vmstat.c --- a/mm/vmstat.c~mm-proc-sys-vm-stat_refresh-to-force-vmstat-update-fix +++ a/mm/vmstat.c @@ -1371,7 +1371,6 @@ static const struct file_operations proc .llseek = seq_lseek, .release = seq_release, }; -#endif /* CONFIG_PROC_FS */ #ifdef CONFIG_SMP static struct workqueue_struct *vmstat_wq; @@ -1436,7 +1435,10 @@ int vmstat_refresh(struct ctl_table *tab *lenp = 0; return 0; } +#endif /* CONFIG_SMP */ +#endif /* CONFIG_PROC_FS */ +#ifdef CONFIG_SMP static void vmstat_update(struct work_struct *w) { if (refresh_cpu_vm_stats(true)) { _ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org