From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: hillf.zj@alibaba-inc.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v5] mm: Add memory allocation watchdog kernel thread.
Date: Thu, 12 May 2016 18:38:25 +0200 [thread overview]
Message-ID: <20160512163824.GA4940@dhcp22.suse.cz> (raw)
In-Reply-To: <201605130009.EAJ35441.JLtFVOHFOSOMQF@I-love.SAKURA.ne.jp>
On Fri 13-05-16 00:09:07, Tetsuo Handa wrote:
[...]
> Michal, this version eliminated overhead of walking the process list
> when nothing is wrong. You are aware of the possibility of
> debug_show_all_locks() failing to report the culprit, aren't you?
> So, what are unacceptable major problems for you?
I do not remember complaining about anything unacceptable for this
patch. I just thought it was way too large the last time I have looked
at it. Johannes was suggesting to simply extend warn_alloc_failed to
also report too many retries with some extended information as a more
lightweight approach. It wouldn't give as much information as your
watchdog but maybe it would be sufficient to figure out that something
really bad is going on. Dunno but I would rather see a more lightweight
debugging aid than a lot of code which sit basically unused most of the
time.
That being said I cannot comment on this particular version as I haven't
checked it properly yet.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-12 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <004b01d1a9d1$3817fc10$a847f430$@alibaba-inc.com>
2016-05-09 9:51 ` Hillf Danton
2016-05-12 15:09 ` Tetsuo Handa
2016-05-12 16:38 ` Michal Hocko [this message]
2016-05-07 14:16 Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512163824.GA4940@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox