From: Andrew Morton <akpm@linux-foundation.org>
To: Minfei Huang <mnghuan@gmail.com>
Cc: labbott@fedoraproject.org, rjw@rjwysocki.net,
mgorman@techsingularity.net, mhocko@suse.com, vbabka@suse.cz,
rientjes@google.com, kirill.shutemov@linux.intel.com,
iamjoonsoo.kim@lge.com, izumi.taku@jp.fujitsu.com,
alexander.h.duyck@redhat.com, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use existing helper to convert "on/off" to boolean
Date: Fri, 29 Apr 2016 14:21:10 -0700 [thread overview]
Message-ID: <20160429142110.b4039a422866754bc914b8b2@linux-foundation.org> (raw)
In-Reply-To: <1461908824-16129-1-git-send-email-mnghuan@gmail.com>
On Fri, 29 Apr 2016 13:47:04 +0800 Minfei Huang <mnghuan@gmail.com> wrote:
> It's more convenient to use existing function helper to convert string
> "on/off" to boolean.
>
> ...
>
> --- a/lib/kstrtox.c
> +++ b/lib/kstrtox.c
> @@ -326,7 +326,7 @@ EXPORT_SYMBOL(kstrtos8);
> * @s: input string
> * @res: result
> *
> - * This routine returns 0 iff the first character is one of 'Yy1Nn0', or
> + * This routine returns 0 if the first character is one of 'Yy1Nn0', or
That isn't actually a typo. "iff" is shorthand for "if and only if".
ie: kstrtobool() will not return 0 in any other case.
Use of "iff" is a bit pretentious but I guess it does convey some
conceivably useful info.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-29 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 5:47 Minfei Huang
2016-04-29 8:04 ` Michal Hocko
2016-04-29 9:07 ` Minfei Huang
2016-04-29 9:21 ` Michal Hocko
2016-04-29 21:21 ` Andrew Morton [this message]
2016-04-30 4:47 ` Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429142110.b4039a422866754bc914b8b2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mnghuan@gmail.com \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox