From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f200.google.com (mail-ob0-f200.google.com [209.85.214.200]) by kanga.kvack.org (Postfix) with ESMTP id 6EF456B0005 for ; Tue, 26 Apr 2016 11:18:43 -0400 (EDT) Received: by mail-ob0-f200.google.com with SMTP id u2so31965421obx.0 for ; Tue, 26 Apr 2016 08:18:43 -0700 (PDT) Received: from relay.sgi.com (relay2.sgi.com. [192.48.180.65]) by mx.google.com with ESMTP id ei6si3953610igb.99.2016.04.26.08.18.42 for ; Tue, 26 Apr 2016 08:18:42 -0700 (PDT) Date: Tue, 26 Apr 2016 10:18:41 -0500 From: Alex Thorlton Subject: Re: [PATCH 14/18] prctl: make PR_SET_THP_DISABLE wait for mmap_sem killable Message-ID: <20160426151841.GQ152091@stormcage.americas.sgi.com> References: <1461675385-5934-1-git-send-email-mhocko@kernel.org> <1461675385-5934-15-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461675385-5934-15-git-send-email-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , LKML , Michal Hocko , Alex Thorlton , Vlastimil Babka On Tue, Apr 26, 2016 at 02:56:21PM +0200, Michal Hocko wrote: > From: Michal Hocko > > PR_SET_THP_DISABLE requires mmap_sem for write. If the waiting > task gets killed by the oom killer it would block oom_reaper from > asynchronous address space reclaim and reduce the chances of timely OOM > resolving. Wait for the lock in the killable mode and return with EINTR > if the task got killed while waiting. > > Cc: Alex Thorlton > Acked-by: Vlastimil Babka > Signed-off-by: Michal Hocko Looks good to me - I wrote that bit of code so I think this can get an: Acked-by: Alex Thorlton Thanks for Ccing me! - Alex -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org