From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 701C16B0005 for ; Fri, 15 Apr 2016 09:08:42 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id l6so18139144wml.3 for ; Fri, 15 Apr 2016 06:08:42 -0700 (PDT) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com. [74.125.82.66]) by mx.google.com with ESMTPS id 15si11943289wms.2.2016.04.15.06.08.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Apr 2016 06:08:41 -0700 (PDT) Received: by mail-wm0-f66.google.com with SMTP id a140so6109574wma.2 for ; Fri, 15 Apr 2016 06:08:41 -0700 (PDT) Date: Fri, 15 Apr 2016 15:08:40 +0200 From: Michal Hocko Subject: Re: [PATCH 17/19] dm: get rid of superfluous gfp flags Message-ID: <20160415130839.GJ32377@dhcp22.suse.cz> References: <1460372892-8157-1-git-send-email-mhocko@kernel.org> <1460372892-8157-18-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Mikulas Patocka Cc: linux-mm@kvack.org, Andrew Morton , LKML , Shaohua Li On Fri 15-04-16 08:29:28, Mikulas Patocka wrote: > > > On Mon, 11 Apr 2016, Michal Hocko wrote: > > > From: Michal Hocko > > > > copy_params seems to be little bit confused about which allocation flags > > to use. It enforces GFP_NOIO even though it uses > > memalloc_noio_{save,restore} which enforces GFP_NOIO at the page > > memalloc_noio_{save,restore} is used because __vmalloc is flawed and > doesn't respect GFP_NOIO properly (it doesn't use gfp flags when > allocating pagetables). Yes and there are no plans to change __vmalloc to properly propagate gfp flags through the whole call chain and that is why we have memalloc_noio thingy. If that ever changes later the GFP_NOIO can be added in favor of memalloc_noio API. Both are clearly redundant. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org