linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Michal Hocko <mhocko@suse.com>
Cc: kbuild-all@01.org, linux-mm@kvack.org
Subject: [memcg:attempts/oom-detection-rework-4.5 363/363] mm/page_alloc.c:3034:4: warning: value computed is not used
Date: Tue, 12 Apr 2016 22:25:11 +0800	[thread overview]
Message-ID: <201604122209.RpIuukNL%fengguang.wu@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git attempts/oom-detection-rework-4.5
head:   8f3c89f13f00171577cf29806390e687426f5a78
commit: 8f3c89f13f00171577cf29806390e687426f5a78 [363/363] mm: use MIGRATE_SYNC in page allocation path
config: openrisc-or1ksim_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 8f3c89f13f00171577cf29806390e687426f5a78
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All warnings (new ones prefixed by >>):

   mm/page_alloc.c: In function 'should_compact_retry':
>> mm/page_alloc.c:3034:4: warning: value computed is not used

vim +3034 mm/page_alloc.c

  3018	should_compact_retry(struct alloc_context *ac, int order, int alloc_flags,
  3019			     enum compact_result compact_result, enum migrate_mode *migrate_mode,
  3020			     int compaction_retries)
  3021	{
  3022		int max_retries = MAX_COMPACT_RETRIES;
  3023	
  3024		if (!order)
  3025			return false;
  3026	
  3027		/*
  3028		 * compaction considers all the zone as desperately out of memory
  3029		 * so it doesn't really make much sense to retry except when the
  3030		 * failure could be caused by weak migration mode.
  3031		 */
  3032		if (compaction_failed(compact_result)) {
  3033			if (*migrate_mode < MIGRATE_SYNC) {
> 3034				*migrate_mode++;
  3035				return true;
  3036			}
  3037			return false;
  3038		}
  3039	
  3040		/*
  3041		 * make sure the compaction wasn't deferred or didn't bail out early
  3042		 * due to locks contention before we declare that we should give up.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 7090 bytes --]

                 reply	other threads:[~2016-04-12 14:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201604122209.RpIuukNL%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox