From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Johannes Weiner <hannes@cmpxchg.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: reclaim highmem zone if buffer_heads is over limit
Date: Tue, 5 Apr 2016 13:37:16 -0700 [thread overview]
Message-ID: <20160405133716.00e0f6ce92dc4bfed50c5334@linux-foundation.org> (raw)
In-Reply-To: <1459727169-5698-1-git-send-email-minchan@kernel.org>
On Mon, 4 Apr 2016 08:46:09 +0900 Minchan Kim <minchan@kernel.org> wrote:
> We have been reclaimed highmem zone if buffer_heads is over limit
> but [1] changed the behavior so it doesn't reclaim highmem zone
> although buffer_heads is over the limit.
> This patch restores the logic.
>
> [1] commit 6b4f7799c6a5 ("mm: vmscan: invoke slab shrinkers from shrink_zone()")
>
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2550,7 +2550,7 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
> sc->gfp_mask |= __GFP_HIGHMEM;
>
> for_each_zone_zonelist_nodemask(zone, z, zonelist,
> - requested_highidx, sc->nodemask) {
> + gfp_zone(sc->gfp_mask), sc->nodemask) {
> enum zone_type classzone_idx;
>
> if (!populated_zone(zone))
Wait wut wot. We broke this over a year ago? Highmem pagecache pages
pinning buffer_head lowmem used to be a huuuge problem. Before most of
you were born ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-05 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 23:46 Minchan Kim
2016-04-05 20:37 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-01 8:00 Minchan Kim
2016-04-01 8:03 ` Michal Hocko
2016-04-01 20:14 ` Andrew Morton
2016-04-03 23:49 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405133716.00e0f6ce92dc4bfed50c5334@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox