From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
David Rientjes <rientjes@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] mm/hugetlb: optimize minimum size (min_size) accounting
Date: Thu, 31 Mar 2016 01:00:03 +0000 [thread overview]
Message-ID: <20160331010002.GA20652@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <1458949498-18916-1-git-send-email-mike.kravetz@oracle.com>
On Fri, Mar 25, 2016 at 04:44:58PM -0700, Mike Kravetz wrote:
> It was observed that minimum size accounting associated with the
> hugetlbfs min_size mount option may not perform optimally and as
> expected. As huge pages/reservations are released from the filesystem
> and given back to the global pools, they are reserved for subsequent
> filesystem use as long as the subpool reserved count is less than
> subpool minimum size. It does not take into account used pages
> within the filesystem. The filesystem size limits are not exceeded
> and this is technically not a bug. However, better behavior would
> be to wait for the number of used pages/reservations associated with
> the filesystem to drop below the minimum size before taking reservations
> to satisfy minimum size.
>
> An optimization is also made to the hugepage_subpool_get_pages()
> routine which is called when pages/reservations are allocated. This
> does not change behavior, but simply avoids the accounting if all
> reservations have already been taken (subpool reserved count == 0).
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Seems OK to me.
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-03-31 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 23:44 Mike Kravetz
2016-03-31 1:00 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331010002.GA20652@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox