From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by kanga.kvack.org (Postfix) with ESMTP id 0BDB26B0253 for ; Fri, 4 Mar 2016 13:02:42 -0500 (EST) Received: by mail-wm0-f49.google.com with SMTP id n186so1872032wmn.1 for ; Fri, 04 Mar 2016 10:02:41 -0800 (PST) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com. [74.125.82.66]) by mx.google.com with ESMTPS id k185si244379wmf.6.2016.03.04.10.02.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Mar 2016 10:02:40 -0800 (PST) Received: by mail-wm0-f66.google.com with SMTP id n186so213974wmn.0 for ; Fri, 04 Mar 2016 10:02:40 -0800 (PST) Date: Fri, 4 Mar 2016 19:02:39 +0100 From: Michal Hocko Subject: Re: [PATCH 1/2] mm: migrate: consolidate mem_cgroup_migrate() calls Message-ID: <20160304180237.GD24204@dhcp22.suse.cz> References: <1454616467-8994-1-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454616467-8994-1-git-send-email-hannes@cmpxchg.org> Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: Andrew Morton , Hugh Dickins , Vladimir Davydov , Mateusz Guzik , Sergey Senozhatsky , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com On Thu 04-02-16 15:07:46, Johannes Weiner wrote: > Rather than scattering mem_cgroup_migrate() calls all over the place, > have a single call from a safe place where every migration operation > eventually ends up in - migrate_page_copy(). This is very nice! > Signed-off-by: Johannes Weiner > Suggested-by: Hugh Dickins Sorry for coming so late. Acked-by: Michal Hocko > --- > mm/migrate.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 17db63b2dd36..90cbf7c65cac 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -331,8 +331,6 @@ int migrate_page_move_mapping(struct address_space *mapping, > if (PageSwapBacked(page)) > SetPageSwapBacked(newpage); > > - mem_cgroup_migrate(page, newpage); > - > return MIGRATEPAGE_SUCCESS; > } > > @@ -428,8 +426,6 @@ int migrate_page_move_mapping(struct address_space *mapping, > } > local_irq_enable(); > > - mem_cgroup_migrate(page, newpage); > - > return MIGRATEPAGE_SUCCESS; > } > > @@ -471,8 +467,6 @@ int migrate_huge_page_move_mapping(struct address_space *mapping, > > spin_unlock_irq(&mapping->tree_lock); > > - mem_cgroup_migrate(page, newpage); > - > return MIGRATEPAGE_SUCCESS; > } > > @@ -586,6 +580,8 @@ void migrate_page_copy(struct page *newpage, struct page *page) > end_page_writeback(newpage); > > copy_page_owner(page, newpage); > + > + mem_cgroup_migrate(page, newpage); > } > > /************************************************************ > @@ -1846,7 +1842,6 @@ fail_putback: > } > > mlock_migrate_page(new_page, page); > - mem_cgroup_migrate(page, new_page); > page_remove_rmap(page, true); > set_page_owner_migrate_reason(new_page, MR_NUMA_MISPLACED); > > -- > 2.7.0 -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org