From: Theodore Ts'o <tytso@mit.edu>
To: Chen Gang <chengang@emindsoft.com.cn>
Cc: Jianyu Zhan <nasa4836@gmail.com>,
Mel Gorman <mgorman@techsingularity.net>,
trivial@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
rientjes@google.com, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
vdavydov@virtuozzo.com, Dan Williams <dan.j.williams@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Fri, 26 Feb 2016 21:45:48 -0500 [thread overview]
Message-ID: <20160227024548.GP1215@thunk.org> (raw)
In-Reply-To: <56D06E8A.9070106@emindsoft.com.cn>
On Fri, Feb 26, 2016 at 11:26:02PM +0800, Chen Gang wrote:
> > As for coding style, actually IMHO this patch is even _not_ a coding
> > style, more like a code shuffle, indeed.
> >
>
> "80 column limitation" is about coding style, I guess, all of us agree
> with it.
No, it's been accepted that checkpatch requiring people to reformat
code to within be 80 columns limitation was actively harmful, and it
no longer does that.
Worse, it now complains when you split a printf string across lines,
so there were patches that split a string across multiple lines to
make checkpatch shut up. And now there are patches that join the
string back together.
And if you now start submitting patches to split them up again because
you think the 80 column restriction is so darned important, that would
be even ***more*** code churn.
Which is one of the reasons why some of us aren't terribly happy with
people who start running checkpatch -file on other people's code and
start submitting patches, either through the trivial patch portal or
not.
Mel, as an MM developer, has already NACK'ed the patch, which means
you should not send the patch to **any** upstream maintainer for
inclusion.
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-02-27 2:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 22:26 chengang
2016-02-25 1:01 ` SeongJae Park
2016-02-25 14:12 ` Chen Gang
2016-02-25 8:57 ` Michal Hocko
2016-02-25 14:23 ` Chen Gang
2016-02-25 14:47 ` Michal Hocko
2016-02-25 22:17 ` Chen Gang
2016-02-25 9:27 ` Mel Gorman
2016-02-25 14:38 ` Chen Gang
2016-02-25 15:12 ` Jiri Kosina
2016-02-25 22:19 ` Chen Gang
2016-02-25 16:07 ` Mel Gorman
2016-02-25 22:29 ` Chen Gang
2016-02-25 22:39 ` Jiri Kosina
2016-02-26 14:57 ` Chen Gang
2016-02-25 23:12 ` SeongJae Park
2016-02-26 15:06 ` Chen Gang
2016-02-26 2:32 ` Jianyu Zhan
2016-02-26 15:26 ` Chen Gang
2016-02-27 2:45 ` Theodore Ts'o [this message]
2016-02-27 14:32 ` Chen Gang
2016-02-27 16:53 ` Theodore Ts'o
2016-02-28 0:21 ` Chen Gang
2016-02-28 13:27 ` Mel Gorman
2016-02-28 15:28 ` Chen Gang
2016-02-27 23:14 ` Jiri Kosina
2016-02-28 0:47 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160227024548.GP1215@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=chengang@emindsoft.com.cn \
--cc=dan.j.williams@intel.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.cz \
--cc=nasa4836@gmail.com \
--cc=rientjes@google.com \
--cc=trivial@kernel.org \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox