From: Mel Gorman <mgorman@techsingularity.net>
To: Chen Gang <chengang@emindsoft.com.cn>
Cc: trivial@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz,
rientjes@google.com, linux-kernel@vger.kernel.org,
mhocko@suse.cz, hannes@cmpxchg.org, vdavydov@virtuozzo.com,
dan.j.williams@intel.com, linux-mm@kvack.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
Date: Thu, 25 Feb 2016 16:07:07 +0000 [thread overview]
Message-ID: <20160225160707.GX2854@techsingularity.net> (raw)
In-Reply-To: <56CF1202.2020809@emindsoft.com.cn>
On Thu, Feb 25, 2016 at 10:38:58PM +0800, Chen Gang wrote:
> On 2/25/16 17:27, Mel Gorman wrote:
> > On Thu, Feb 25, 2016 at 06:26:31AM +0800, chengang@emindsoft.com.cn wrote:
> >> From: Chen Gang <chengang@emindsoft.com.cn>
> >>
> >> Always notice about 80 columns, and the white space near '|'.
> >>
> >> Let the wrapped function parameters align as the same styles.
> >>
> >> Remove redundant statement "enum zone_type z;" in function gfp_zone.
> >>
> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> >
> > NAK from me at least. From my perspective, it's preferrable to preserve
> > blame than go through a layer of cleanup when looking for the commit
> > that defined particular flags. It's ok to cleanup code at the same time
> > definitions change for functional or performance reasons.
> >
>
> I can understand for your NAK, it is a trivial patch. For me, I guess
> trivial@kernel.org will care about this kind of patch.
>
I do not want this patch to go through the trivial tree. It still adds
another step to identifying relevant commits through git blame and has
limited, if any, benefit to maintainability.
> "it's preferable to preserve blame than go through a layer of cleanup
> when looking for the commit that defined particular flags".
>
git blame identifies what commit last altered a line. If a cleanup patch
is encountered then the tree before that commit needs to be examined
which adds time. It's rare that cleanup patches on their own are useful
and this is one of those cases.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-02-25 16:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 22:26 chengang
2016-02-25 1:01 ` SeongJae Park
2016-02-25 14:12 ` Chen Gang
2016-02-25 8:57 ` Michal Hocko
2016-02-25 14:23 ` Chen Gang
2016-02-25 14:47 ` Michal Hocko
2016-02-25 22:17 ` Chen Gang
2016-02-25 9:27 ` Mel Gorman
2016-02-25 14:38 ` Chen Gang
2016-02-25 15:12 ` Jiri Kosina
2016-02-25 22:19 ` Chen Gang
2016-02-25 16:07 ` Mel Gorman [this message]
2016-02-25 22:29 ` Chen Gang
2016-02-25 22:39 ` Jiri Kosina
2016-02-26 14:57 ` Chen Gang
2016-02-25 23:12 ` SeongJae Park
2016-02-26 15:06 ` Chen Gang
2016-02-26 2:32 ` Jianyu Zhan
2016-02-26 15:26 ` Chen Gang
2016-02-27 2:45 ` Theodore Ts'o
2016-02-27 14:32 ` Chen Gang
2016-02-27 16:53 ` Theodore Ts'o
2016-02-28 0:21 ` Chen Gang
2016-02-28 13:27 ` Mel Gorman
2016-02-28 15:28 ` Chen Gang
2016-02-27 23:14 ` Jiri Kosina
2016-02-28 0:47 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225160707.GX2854@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=chengang@emindsoft.com.cn \
--cc=dan.j.williams@intel.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=trivial@kernel.org \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox