From: Andrew Morton <akpm@linux-foundation.org>
To: Christoph Lameter <cl@linux.com>
Cc: Michal Hocko <mhocko@kernel.org>, Tejun Heo <htejun@gmail.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-mm@kvack.org, hannes@cmpxchg.org, mgorman@suse.de
Subject: Re: [patch 2/2] vmstat: Get rid of the ugly cpu_stat_off variable
Date: Tue, 23 Feb 2016 16:23:45 -0800 [thread overview]
Message-ID: <20160223162345.51f8494cb1484ad5cb7f8eab@linux-foundation.org> (raw)
In-Reply-To: <20160222181049.953663183@linux.com>
On Mon, 22 Feb 2016 12:10:42 -0600 Christoph Lameter <cl@linux.com> wrote:
> The cpu_stat_off variable is unecessary since we can check if
> a workqueue request is pending otherwise. This makes it pretty
> easy for the shepherd to ensure that the proper things happen.
>
> Removing the state also removes all races related to it.
> Should a workqueue not be scheduled as needed for vmstat_update
> then the shepherd will notice and schedule it as needed.
> Should a workqueue be unecessarily scheduled then the vmstat
> updater will disable it.
>
> Thus vmstat_idle can also be simplified.
I'm getting rather a lot of rejects from this one.
>
> @@ -1436,11 +1426,8 @@ void quiet_vmstat(void)
> if (system_state != SYSTEM_RUNNING)
> return;
>
> - do {
> - if (!cpumask_test_and_set_cpu(smp_processor_id(), cpu_stat_off))
> - cancel_delayed_work(this_cpu_ptr(&vmstat_work));
> -
> - } while (refresh_cpu_vm_stats(false));
> + refresh_cpu_vm_stats(false);
> + cancel_delayed_work(this_cpu_ptr(&vmstat_work));
> }
I can't find a quiet_vmstat() which looks like this. What tree are you
patching?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-02-24 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 18:10 [patch 0/2] vmstat: Speedup and Cleanup Christoph Lameter
2016-02-22 18:10 ` [patch 1/2] vmstat: Optimize refresh_cpu_vmstat() Christoph Lameter
2016-02-24 17:38 ` Michal Hocko
2016-02-22 18:10 ` [patch 2/2] vmstat: Get rid of the ugly cpu_stat_off variable Christoph Lameter
2016-02-24 0:23 ` Andrew Morton [this message]
2016-02-24 10:07 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223162345.51f8494cb1484ad5cb7f8eab@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=htejun@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox