From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCHv6] mm: slab: free kmem_cache_node after destroy sysfs file
Date: Fri, 5 Feb 2016 19:54:54 +0300 [thread overview]
Message-ID: <20160205165454.GB22456@esperanza> (raw)
In-Reply-To: <56B4D171.6000000@virtuozzo.com>
On Fri, Feb 05, 2016 at 07:44:33PM +0300, Dmitry Safonov wrote:
...
> >>@@ -2414,8 +2415,6 @@ int __kmem_cache_shrink(struct kmem_cache *cachep, bool deactivate)
> >> int __kmem_cache_shutdown(struct kmem_cache *cachep)
> >> {
> >>- int i;
> >>- struct kmem_cache_node *n;
> >> int rc = __kmem_cache_shrink(cachep, false);
> >> if (rc)
> >>@@ -2423,6 +2422,14 @@ int __kmem_cache_shutdown(struct kmem_cache *cachep)
> >> free_percpu(cachep->cpu_cache);
> >And how come ->cpu_cache (and ->cpu_slab in case of SLUB) is special?
> >Can't sysfs access it either? I propose to introduce a method called
> >__kmem_cache_release (instead of __kmem_cache_free_nodes), which would
> >do all freeing, both per-cpu and per-node.
> AFAICS, they aren't used by this sysfs.
They are: alloc_calls_show -> list_locations -> flush_all accesses
->cpu_slab.
Thanks,
Vladimir
> Anyway, seems reasonable, will do.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-02-05 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 15:45 Dmitry Safonov
2016-02-05 16:11 ` Vladimir Davydov
2016-02-05 16:44 ` Dmitry Safonov
2016-02-05 16:54 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160205165454.GB22456@esperanza \
--to=vdavydov@virtuozzo.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dsafonov@virtuozzo.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox