linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: hannes@cmpxchg.org
Cc: mhocko@kernel.org, rientjes@google.com, jstancek@redhat.com,
	linux-mm@kvack.org
Subject: Re: [RFC][PATCH] mm, page_alloc: Warn on !__GFP_NOWARN allocation from IRQ context.
Date: Wed, 3 Feb 2016 19:40:52 +0900	[thread overview]
Message-ID: <201602031940.IFH52643.JLOOFtMQOFFHVS@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20160202161421.GA30012@cmpxchg.org>

Johannes Weiner wrote:
> On Tue, Feb 02, 2016 at 10:33:22PM +0900, Tetsuo Handa wrote:
> > >From 20b3c1c9ef35547395c3774c6208a867cf0046d4 Mon Sep 17 00:00:00 2001
> > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Date: Tue, 2 Feb 2016 16:50:45 +0900
> > Subject: [RFC][PATCH] mm, page_alloc: Warn on !__GFP_NOWARN allocation from IRQ context.
> > 
> > Jan Stancek hit a hard lockup problem due to flood of memory allocation
> > failure messages which lasted for 10 seconds with IRQ disabled. Printing
> > traces using warn_alloc_failed() is very slow (which can take up to about
> > 1 second for each warn_alloc_failed() call). The caller used GFP_NOWARN

                                                                s/GFP_NOWARN/GFP_NOWAIT/

> > inside a loop. If the caller used __GFP_NOWARN, it would not have lasted
> > for 10 seconds.
> 
> Who is doing page allocations in a loop with irqs disabled?!

lib/dma-debug.c functions which are called with irqs disabled.
http://lkml.kernel.org/r/201601292135.DHG60988.SOQFJFOHFVMLOt@I-love.SAKURA.ne.jp

> 
> And then, why does it take that long? Is that a serial console? Most
> of the output is KERN_INFO, it might be better to raise the loglevel
> and still have all the debugging output in the logs.

Yes, I think it is a serial console.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-02-03 10:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 13:33 Tetsuo Handa
2016-02-02 16:14 ` Johannes Weiner
2016-02-03 10:40   ` Tetsuo Handa [this message]
2016-02-03 23:30 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201602031940.IFH52643.JLOOFtMQOFFHVS@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=hannes@cmpxchg.org \
    --cc=jstancek@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox