From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by kanga.kvack.org (Postfix) with ESMTP id 842656B0005 for ; Tue, 26 Jan 2016 21:15:16 -0500 (EST) Received: by mail-pf0-f172.google.com with SMTP id 65so21315062pfd.2 for ; Tue, 26 Jan 2016 18:15:16 -0800 (PST) Received: from lgeamrelo12.lge.com (LGEAMRELO12.lge.com. [156.147.23.52]) by mx.google.com with ESMTPS id y15si5814123pfa.162.2016.01.26.18.15.15 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jan 2016 18:15:15 -0800 (PST) Date: Wed, 27 Jan 2016 11:15:15 +0900 From: Joonsoo Kim Subject: Re: [RFC PATCH] mm: support CONFIG_ZONE_DEVICE + CONFIG_ZONE_DMA Message-ID: <20160127021515.GA7562@js1304-P5Q-DELUXE> References: <20160126000639.358.89668.stgit@dwillia2-desk3.amr.corp.intel.com> <20160126141152.e1043d14502dcca17813afb3@linux-foundation.org> <20160126145153.44e4f38b04200209d133c0a3@linux-foundation.org> <20160127011817.GA7398@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: Andrew Morton , Rik van Riel , linux-nvdimm , Dave Hansen , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Linux MM , Ingo Molnar , Mel Gorman , "H. Peter Anvin" , Jerome Glisse , Sudip Mukherjee On Tue, Jan 26, 2016 at 05:37:38PM -0800, Dan Williams wrote: > On Tue, Jan 26, 2016 at 5:18 PM, Joonsoo Kim wrote: > > Hello, > > > > On Tue, Jan 26, 2016 at 03:11:36PM -0800, Dan Williams wrote: > >> On Tue, Jan 26, 2016 at 2:51 PM, Andrew Morton > >> wrote: > >> > On Tue, 26 Jan 2016 14:33:48 -0800 Dan Williams wrote: > >> > > >> >> >> Towards this end, alias ZONE_DMA and ZONE_DEVICE to work around needing > >> >> >> to maintain a unique zone number for ZONE_DEVICE. Record the geometry > >> >> >> of ZONE_DMA at init (->init_spanned_pages) and use that information in > >> >> >> is_zone_device_page() to differentiate pages allocated via > >> >> >> devm_memremap_pages() vs true ZONE_DMA pages. Otherwise, use the > >> >> >> simpler definition of is_zone_device_page() when ZONE_DMA is turned off. > >> >> >> > >> >> >> Note that this also teaches the memory hot remove path that the zone may > >> >> >> not have sections for all pfn spans (->zone_dyn_start_pfn). > >> >> >> > >> >> >> A user visible implication of this change is potentially an unexpectedly > >> >> >> high "spanned" value in /proc/zoneinfo for the DMA zone. > >> >> > > >> >> > Well, all these icky tricks are to avoid increasing ZONES_SHIFT, yes? > >> >> > Is it possible to just use ZONES_SHIFT=3? > >> >> > >> >> Last I tried I hit this warning in mm/memory.c > >> >> > >> >> #warning Unfortunate NUMA and NUMA Balancing config, growing > >> >> page-frame for last_cpupid. > >> > > >> > Well yes, it may take a bit of work - perhaps salvaging a bit from > >> > somewhere else if poss. But that might provide a better overall > >> > solution so could you please have a think? > >> > > >> > >> Will do, especially since other efforts are feeling the pinch on the > >> MAX_NR_ZONES limitation. > > > > Please refer my previous attempt to add a new zone, ZONE_CMA. > > > > https://lkml.org/lkml/2015/2/12/84 > > > > It salvages a bit from SECTION_WIDTH by increasing section size. > > Similarly, I guess we can reduce NODE_WIDTH if needed although > > it could cause to reduce maximum node size. > > Dave pointed out to me that LAST__PID_SHIFT might be a better > candidate to reduce to 7 bits. That field is for storing pids which > are already bigger than 8 bits. If it is relying on the fact that > pids don't rollover very often then likely the impact of 7-bits > instead of 8 will be minimal. Hmm... I'm not sure it's possible or not, but, it looks not a general solution. It will solve your problem because you are using 64 bit arch but other 32 bit archs can't get the benefit. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org