From: Andrew Morton <akpm@linux-foundation.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Subject: Re: [PATCH v2 2/2] mm: soft-offline: exit with failure for non anonymous thp
Date: Tue, 12 Jan 2016 15:49:59 -0800 [thread overview]
Message-ID: <20160112154959.009a3944dd094dc2234e2f65@linux-foundation.org> (raw)
In-Reply-To: <1452568245-10412-3-git-send-email-n-horiguchi@ah.jp.nec.com>
On Tue, 12 Jan 2016 12:10:45 +0900 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> Currently memory_failure() doesn't handle non anonymous thp case, because we
> can hardly expect the error handling to be successful, and it can just hit
> some corner case which results in BUG_ON or something severe like that.
> This is also the case for soft offline code, so let's make it in the same way.
>
> Orignal code has a MF_COUNT_INCREASED check before put_hwpoison_page(), but
> it's unnecessary because get_any_page() is already called when running on
> this code, which takes a refcount of the target page regardress of the flag.
> So this patch also removes it.
>
> ...
>
> --- next-20160111/mm/memory-failure.c
> +++ next-20160111_patched/mm/memory-failure.c
> @@ -1691,16 +1691,16 @@ static int soft_offline_in_use_page(struct page *page, int flags)
>
> if (!PageHuge(page) && PageTransHuge(hpage)) {
> lock_page(hpage);
> - ret = split_huge_page(hpage);
> - unlock_page(hpage);
> - if (unlikely(ret || PageTransCompound(page) ||
> - !PageAnon(page))) {
> - pr_info("soft offline: %#lx: failed to split THP\n",
> - page_to_pfn(page));
> - if (flags & MF_COUNT_INCREASED)
> - put_hwpoison_page(hpage);
> + if (!PageAnon(hpage) || unlikely(split_huge_page(hpage))) {
> + unlock_page(hpage);
> + if (!PageAnon(hpage))
> + pr_info("soft offline: %#lx: non anonymous thp\n", pfn);
> + else
> + pr_info("soft offline: %#lx: thp split failed\n", pfn);
> + put_hwpoison_page(hpage);
> return -EBUSY;
> }
hm, what happened there.
mm/memory-failure.c: In function 'soft_offline_in_use_page':
mm/memory-failure.c:1697: error: 'pfn' undeclared (first use in this function)
mm/memory-failure.c:1697: error: (Each undeclared identifier is reported only once
mm/memory-failure.c:1697: error: for each function it appears in.)
--- a/mm/memory-failure.c~mm-soft-offline-exit-with-failure-for-non-anonymous-thp-fix
+++ a/mm/memory-failure.c
@@ -1694,9 +1694,9 @@ static int soft_offline_in_use_page(stru
if (!PageAnon(hpage) || unlikely(split_huge_page(hpage))) {
unlock_page(hpage);
if (!PageAnon(hpage))
- pr_info("soft offline: %#lx: non anonymous thp\n", pfn);
+ pr_info("soft offline: %#lx: non anonymous thp\n", page_to_pfn(page));
else
- pr_info("soft offline: %#lx: thp split failed\n", pfn);
+ pr_info("soft offline: %#lx: thp split failed\n", page_to_pfn(page));
put_hwpoison_page(hpage);
return -EBUSY;
}
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-01-12 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 7:24 [PATCH v1] " Naoya Horiguchi
2016-01-08 20:33 ` Andrew Morton
2016-01-12 3:10 ` Naoya Horiguchi
2016-01-12 3:10 ` [PATCH v2 1/2] mm: soft-offline: clean up soft_offline_page() Naoya Horiguchi
2016-01-12 3:10 ` [PATCH v2 2/2] mm: soft-offline: exit with failure for non anonymous thp Naoya Horiguchi
2016-01-12 23:49 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112154959.009a3944dd094dc2234e2f65@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nao.horiguchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox