From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id 7FB026B02F4 for ; Fri, 25 Dec 2015 06:44:31 -0500 (EST) Received: by mail-wm0-f54.google.com with SMTP id p187so199106642wmp.0 for ; Fri, 25 Dec 2015 03:44:31 -0800 (PST) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com. [74.125.82.49]) by mx.google.com with ESMTPS id e196si63691021wmd.100.2015.12.25.03.44.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Dec 2015 03:44:30 -0800 (PST) Received: by mail-wm0-f49.google.com with SMTP id l126so200994318wml.1 for ; Fri, 25 Dec 2015 03:44:30 -0800 (PST) Date: Fri, 25 Dec 2015 12:44:29 +0100 From: Michal Hocko Subject: Re: [PATCH 1/2] mm, oom: introduce oom reaper Message-ID: <20151225114428.GC6754@dhcp22.suse.cz> References: <1450204575-13052-1-git-send-email-mhocko@kernel.org> <20151224094758.GA22760@dhcp22.suse.cz> <20151225113537.GA6754@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151225113537.GA6754@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Ross Zwisler Cc: Andrew Morton , Mel Gorman , Tetsuo Handa , David Rientjes , Linus Torvalds , Oleg Nesterov , Hugh Dickins , Andrea Argangeli , Rik van Riel , linux-mm@kvack.org, LKML , Ross Zwisler On Fri 25-12-15 12:35:37, Michal Hocko wrote: [...] > Thanks I will try to reproduce early next year. But so far I think this > is just a general issue of MADV_DONTNEED vs. truncate and oom_reaper is > just lucky to trigger it. There shouldn't be anything oom_reaper > specific here. Maybe there is some additional locking missing? Hmm, scratch that. I think Tetsuo has nailed it. It seems like the missing initialization of details structure during unmap is the culprit. So there most probably was on OOM killing invoked. It is just a side effect of the patch and missing http://marc.info/?l=linux-mm&m=145068666428057 follow up fix. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org