From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/swapfile: mm/swapfile: fix swapoff vs. software dirty bits
Date: Fri, 18 Dec 2015 08:41:32 +0100 [thread overview]
Message-ID: <20151218084132.7661051e@mschwide> (raw)
In-Reply-To: <CAM5jBj5vOTjbt1f3Z6P=qQymX5-_W6bLGVQ1Q9FERx6tpKbthQ@mail.gmail.com>
On Thu, 17 Dec 2015 19:08:46 +0300
Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> On Mon, Sep 14, 2015 at 12:24 PM, Martin Schwidefsky
> <schwidefsky@de.ibm.com> wrote:
> > Fixes a regression introduced with commit 179ef71cbc085252
> > "mm: save soft-dirty bits on swapped pages"
> >
> > The maybe_same_pte() function is used to match a swap pte independent
> > of the swap software dirty bit set with pte_swp_mksoft_dirty().
> >
> > For CONFIG_HAVE_ARCH_SOFT_DIRTY=y but CONFIG_MEM_SOFT_DIRTY=n the
> > software dirty bit may be set but maybe_same_pte() will not recognize
> > a software dirty swap pte. Due to this a 'swapoff -a' will hang.
> >
> > The straightforward solution is to replace CONFIG_MEM_SOFT_DIRTY
> > with HAVE_ARCH_SOFT_DIRTY in maybe_same_pte().
> >
> > Cc: linux-mm@kvack.org
> > Cc: Cyrill Gorcunov <gorcunov@gmail.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Michal Hocko <mhocko@suse.cz>
> > Reported-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
> > Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> We've been discussing this already
> http://comments.gmane.org/gmane.linux.kernel.mm/138664
Yes indeed. I'm still trying to find out how this mail has been
sent a second time. That was not intentional, sorry for the noise.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-12-18 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 9:24 [PATCH] hanging swapoff with HAVE_ARCH_SOFT_DIRTY=y Martin Schwidefsky
2015-09-14 9:24 ` [PATCH] mm/swapfile: mm/swapfile: fix swapoff vs. software dirty bits Martin Schwidefsky
2015-12-17 16:08 ` Cyrill Gorcunov
2015-12-18 7:41 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218084132.7661051e@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox