From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by kanga.kvack.org (Postfix) with ESMTP id 8FFEA6B0255 for ; Wed, 16 Dec 2015 14:16:25 -0500 (EST) Received: by mail-lf0-f44.google.com with SMTP id z124so31669124lfa.3 for ; Wed, 16 Dec 2015 11:16:25 -0800 (PST) Received: from mail.skyhub.de (mail.skyhub.de. [2a01:4f8:120:8448::d00d]) by mx.google.com with ESMTP id nz9si4933579lbb.109.2015.12.16.11.16.23 for ; Wed, 16 Dec 2015 11:16:24 -0800 (PST) Date: Wed, 16 Dec 2015 20:16:15 +0100 From: Borislav Petkov Subject: Re: [PATCH 01/11] resource: Add System RAM resource type Message-ID: <20151216191614.GK29775@pd.tnic> References: <1450136246-17053-1-git-send-email-toshi.kani@hpe.com> <20151216122642.GE29775@pd.tnic> <1450280642.29051.76.camel@hpe.com> <20151216154916.GF29775@pd.tnic> <1450283759.20148.11.camel@hpe.com> <20151216174523.GH29775@pd.tnic> <20151216181712.GJ29775@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dan Williams Cc: Toshi Kani , Andrew Morton , linux-arch@vger.kernel.org, Linux MM , "linux-kernel@vger.kernel.org" , Linus Torvalds , "Rafael J. Wysocki" On Wed, Dec 16, 2015 at 10:57:52AM -0800, Dan Williams wrote: > Aside from "System RAM" checks I don't think any of these strcmp > usages are in fast paths. Sure, 0.1% slowdown here, 0.2% slowdown there... this is how you get a bloated kernel. In addition to that, using strings to identify resources is ugly. "It was there so we used it" is not an excuse. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org