From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) by kanga.kvack.org (Postfix) with ESMTP id 995B26B0038 for ; Wed, 16 Dec 2015 12:45:34 -0500 (EST) Received: by mail-lb0-f173.google.com with SMTP id yq9so11253649lbb.3 for ; Wed, 16 Dec 2015 09:45:34 -0800 (PST) Received: from mail.skyhub.de (mail.skyhub.de. [2a01:4f8:120:8448::d00d]) by mx.google.com with ESMTP id 11si4641336lfu.47.2015.12.16.09.45.32 for ; Wed, 16 Dec 2015 09:45:32 -0800 (PST) Date: Wed, 16 Dec 2015 18:45:23 +0100 From: Borislav Petkov Subject: Re: [PATCH 01/11] resource: Add System RAM resource type Message-ID: <20151216174523.GH29775@pd.tnic> References: <1450136246-17053-1-git-send-email-toshi.kani@hpe.com> <20151216122642.GE29775@pd.tnic> <1450280642.29051.76.camel@hpe.com> <20151216154916.GF29775@pd.tnic> <1450283759.20148.11.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1450283759.20148.11.camel@hpe.com> Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Linus Torvalds , "Rafael J. Wysocki" , Dan Williams On Wed, Dec 16, 2015 at 09:35:59AM -0700, Toshi Kani wrote: > We do not have enough bits left to cover any potential future use-cases > with other strings if we are going to get rid of strcmp() completely. Look at the examples I gave. I'm talking about having an additional identifier which can be a number and not a bit. > Since the searches from crash and kexec are one-time thing, and einj > is a R&D tool, I think we can leave the strcmp() check for these > special cases, and keep the interface flexible with any strings. I don't think using strings is anywhere close to flexible. If at all, it is an odd use case which shouldnt've been allowed in in the first place. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org