From: Dave Hansen <dave@sr71.net>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, Dave Hansen <dave@sr71.net>,
dave.hansen@linux.intel.com
Subject: [PATCH 27/32] x86: separate out LDT init from context init
Date: Mon, 14 Dec 2015 11:06:26 -0800 [thread overview]
Message-ID: <20151214190626.26611062@viggo.jf.intel.com> (raw)
In-Reply-To: <20151214190542.39C4886D@viggo.jf.intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
The arch-specific mm_context_t is a great place to put
protection-key allocation state.
But, we need to initialize the allocation state because pkey 0 is
always "allocated". All of the runtime initialization of
mm_context_t is done in *_ldt() manipulation functions. This
renames the existing LDT functions like this:
init_new_context() -> init_new_context_ldt()
destroy_context() -> destroy_context_ldt()
and makes init_new_context() and destroy_context() available for
generic use.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
---
b/arch/x86/include/asm/mmu_context.h | 21 ++++++++++++++++-----
b/arch/x86/kernel/ldt.c | 4 ++--
2 files changed, 18 insertions(+), 7 deletions(-)
diff -puN arch/x86/include/asm/mmu_context.h~pkeys-72-init-ldt-extricate arch/x86/include/asm/mmu_context.h
--- a/arch/x86/include/asm/mmu_context.h~pkeys-72-init-ldt-extricate 2015-12-14 10:42:51.088174309 -0800
+++ b/arch/x86/include/asm/mmu_context.h 2015-12-14 10:42:51.093174534 -0800
@@ -52,15 +52,15 @@ struct ldt_struct {
/*
* Used for LDT copy/destruction.
*/
-int init_new_context(struct task_struct *tsk, struct mm_struct *mm);
-void destroy_context(struct mm_struct *mm);
+int init_new_context_ldt(struct task_struct *tsk, struct mm_struct *mm);
+void destroy_context_ldt(struct mm_struct *mm);
#else /* CONFIG_MODIFY_LDT_SYSCALL */
-static inline int init_new_context(struct task_struct *tsk,
- struct mm_struct *mm)
+static inline int init_new_context_ldt(struct task_struct *tsk,
+ struct mm_struct *mm)
{
return 0;
}
-static inline void destroy_context(struct mm_struct *mm) {}
+static inline void destroy_context_ldt(struct mm_struct *mm) {}
#endif
static inline void load_mm_ldt(struct mm_struct *mm)
@@ -104,6 +104,17 @@ static inline void enter_lazy_tlb(struct
#endif
}
+static inline int init_new_context(struct task_struct *tsk,
+ struct mm_struct *mm)
+{
+ init_new_context_ldt(tsk, mm);
+ return 0;
+}
+static inline void destroy_context(struct mm_struct *mm)
+{
+ destroy_context_ldt(mm);
+}
+
static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next,
struct task_struct *tsk)
{
diff -puN arch/x86/kernel/ldt.c~pkeys-72-init-ldt-extricate arch/x86/kernel/ldt.c
--- a/arch/x86/kernel/ldt.c~pkeys-72-init-ldt-extricate 2015-12-14 10:42:51.090174399 -0800
+++ b/arch/x86/kernel/ldt.c 2015-12-14 10:42:51.094174578 -0800
@@ -103,7 +103,7 @@ static void free_ldt_struct(struct ldt_s
* we do not have to muck with descriptors here, that is
* done in switch_mm() as needed.
*/
-int init_new_context(struct task_struct *tsk, struct mm_struct *mm)
+int init_new_context_ldt(struct task_struct *tsk, struct mm_struct *mm)
{
struct ldt_struct *new_ldt;
struct mm_struct *old_mm;
@@ -144,7 +144,7 @@ out_unlock:
*
* 64bit: Don't touch the LDT register - we're already in the next thread.
*/
-void destroy_context(struct mm_struct *mm)
+void destroy_context_ldt(struct mm_struct *mm)
{
free_ldt_struct(mm->context.ldt);
mm->context.ldt = NULL;
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-14 19:06 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 19:05 [PATCH 00/32] x86: Memory Protection Keys (v7) Dave Hansen
2015-12-14 19:05 ` [PATCH 01/32] mm, gup: introduce concept of "foreign" get_user_pages() Dave Hansen
2016-01-05 10:51 ` Vlastimil Babka
2016-01-06 17:43 ` Dave Hansen
2015-12-14 19:05 ` [PATCH 02/32] x86, fpu: add placeholder for Processor Trace XSAVE state Dave Hansen
2015-12-14 19:05 ` [PATCH 03/32] x86, pkeys: Add Kconfig option Dave Hansen
2015-12-14 19:05 ` [PATCH 04/32] x86, pkeys: cpuid bit definition Dave Hansen
2015-12-14 19:05 ` [PATCH 05/32] x86, pkeys: define new CR4 bit Dave Hansen
2015-12-14 19:05 ` [PATCH 06/32] x86, pkeys: add PKRU xsave fields and data structure(s) Dave Hansen
2015-12-14 19:05 ` [PATCH 07/32] x86, pkeys: PTE bits for storing protection key Dave Hansen
2015-12-14 19:05 ` [PATCH 08/32] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2015-12-14 19:06 ` [PATCH 09/32] x86, pkeys: store protection in high VMA flags Dave Hansen
2015-12-14 19:06 ` [PATCH 10/32] x86, pkeys: arch-specific protection bits Dave Hansen
2015-12-14 19:06 ` [PATCH 11/32] x86, pkeys: pass VMA down in to fault signal generation code Dave Hansen
2015-12-14 19:06 ` [PATCH 12/32] signals, pkeys: notify userspace about protection key faults Dave Hansen
2015-12-14 19:06 ` [PATCH 13/32] x86, pkeys: fill in pkey field in siginfo Dave Hansen
2015-12-14 19:06 ` [PATCH 14/32] x86, pkeys: add functions to fetch PKRU Dave Hansen
2015-12-14 19:56 ` Thomas Gleixner
2015-12-14 19:06 ` [PATCH 15/32] mm: factor out VMA fault permission checking Dave Hansen
2015-12-14 19:06 ` [PATCH 16/32] x86, mm: simplify get_user_pages() PTE bit handling Dave Hansen
2015-12-14 19:56 ` Thomas Gleixner
2015-12-14 19:06 ` [PATCH 17/32] x86, pkeys: check VMAs and PTEs for protection keys Dave Hansen
2015-12-14 19:06 ` [PATCH 18/32] mm: add gup flag to indicate "foreign" mm access Dave Hansen
2015-12-14 19:06 ` [PATCH 19/32] x86, pkeys: optimize fault handling in access_error() Dave Hansen
2015-12-14 19:06 ` [PATCH 20/32] x86, pkeys: differentiate instruction fetches Dave Hansen
2015-12-14 19:06 ` [PATCH 21/32] x86, pkeys: dump PKRU with other kernel registers Dave Hansen
2015-12-14 19:06 ` [PATCH 22/32] x86, pkeys: dump PTE pkey in /proc/pid/smaps Dave Hansen
2016-01-05 13:32 ` Vlastimil Babka
2016-01-06 17:46 ` Dave Hansen
2015-12-14 19:06 ` [PATCH 23/32] x86, pkeys: add Kconfig prompt to existing config option Dave Hansen
2015-12-14 19:06 ` [PATCH 24/32] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2015-12-14 20:00 ` Thomas Gleixner
2015-12-14 19:06 ` [PATCH 25/32] mm, multi-arch: pass a protection key in to calc_vm_flag_bits() Dave Hansen
2015-12-14 19:06 ` [PATCH 26/32] x86, pkeys: add arch_validate_pkey() Dave Hansen
2015-12-14 19:06 ` Dave Hansen [this message]
2015-12-14 19:06 ` [PATCH 28/32] x86, fpu: allow setting of XSAVE state Dave Hansen
2015-12-14 19:06 ` [PATCH 29/32] x86, pkeys: allow kernel to modify user pkey rights register Dave Hansen
2015-12-14 19:06 ` [PATCH 30/32] x86, pkeys: create an x86 arch_calc_vm_prot_bits() for VMA flags Dave Hansen
2015-12-14 19:06 ` [PATCH 31/32] x86, pkeys: execute-only support Dave Hansen
2015-12-14 20:05 ` Kees Cook
2015-12-14 23:37 ` Dave Hansen
2015-12-14 23:39 ` Andy Lutomirski
2015-12-14 23:41 ` Kees Cook
2015-12-14 23:44 ` Dave Hansen
2015-12-14 23:47 ` Andy Lutomirski
2015-12-15 0:26 ` Dave Hansen
2015-12-14 23:39 ` Kees Cook
2015-12-14 19:06 ` [PATCH 32/32] x86, pkeys: Documentation Dave Hansen
2015-12-24 11:37 ` [PATCH 00/32] x86: Memory Protection Keys (v7) Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214190626.26611062@viggo.jf.intel.com \
--to=dave@sr71.net \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox