From: Johannes Weiner <hannes@cmpxchg.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] Documentation: cgroup: add memory.swap.{current,max} description
Date: Fri, 11 Dec 2015 14:42:54 -0500 [thread overview]
Message-ID: <20151211194254.GF3773@cmpxchg.org> (raw)
In-Reply-To: <24930f544e7e98a23a17c9adcacb9397b1b8cae7.1449742561.git.vdavydov@virtuozzo.com>
On Thu, Dec 10, 2015 at 02:39:20PM +0300, Vladimir Davydov wrote:
> Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Can we include a blurb for R-5-1 of cgroups.txt as well to explain why
cgroup2 has a new swap interface? I had already written something up
in the past, pasted below, feel free to use it if you like. Otherwise,
you had pretty good reasons in your swap controller changelog as well.
---
- The combined memory+swap accounting and limiting is replaced by real
control over swap space.
memory.swap.current
The amount memory of this subtree that has been swapped to
disk.
memory.swap.max
The maximum amount of memory this subtree is allowed to swap
to disk.
The main argument for a combined memory+swap facility in the
original cgroup design was that global or parental pressure would
always be able to swap all anonymous memory of a child group,
regardless of the child's own (possibly untrusted) configuration.
However, untrusted groups can sabotage swapping by other means--such
as referencing its anonymous memory in a tight loop--and an admin
can not assume full swappability when overcommitting untrusted jobs.
For trusted jobs, on the other hand, a combined counter is not an
intuitive userspace interface, and it flies in the face of the idea
that cgroup controllers should account and limit specific physical
resources. Swap space is a resource like all others in the system,
and that's why unified hierarchy allows distributing it separately.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-11 19:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 11:39 [PATCH 0/7] Add swap accounting to cgroup2 Vladimir Davydov
2015-12-10 11:39 ` [PATCH 1/7] mm: memcontrol: charge swap " Vladimir Davydov
2015-12-10 16:00 ` Johannes Weiner
2015-12-10 17:00 ` Vladimir Davydov
2015-12-11 2:48 ` Kamezawa Hiroyuki
2015-12-11 7:39 ` Vladimir Davydov
2015-12-14 15:30 ` Michal Hocko
2015-12-14 15:48 ` Johannes Weiner
2015-12-14 19:42 ` Vladimir Davydov
2015-12-14 19:52 ` One Thousand Gnomes
2015-12-15 3:22 ` Kamezawa Hiroyuki
2015-12-15 11:02 ` Vladimir Davydov
2015-12-16 2:44 ` Kamezawa Hiroyuki
2015-12-15 14:50 ` Johannes Weiner
2015-12-16 3:18 ` Kamezawa Hiroyuki
2015-12-16 11:09 ` Johannes Weiner
2015-12-17 2:46 ` Kamezawa Hiroyuki
2015-12-17 3:32 ` Johannes Weiner
2015-12-17 4:29 ` Kamezawa Hiroyuki
2015-12-15 17:21 ` Michal Hocko
2015-12-15 20:22 ` Johannes Weiner
2015-12-16 3:57 ` Kamezawa Hiroyuki
2015-12-15 3:12 ` Kamezawa Hiroyuki
2015-12-15 8:30 ` Vladimir Davydov
2015-12-15 9:29 ` Kamezawa Hiroyuki
2015-12-10 11:39 ` [PATCH 2/7] mm: vmscan: pass memcg to get_scan_count() Vladimir Davydov
2015-12-11 19:24 ` Johannes Weiner
2015-12-10 11:39 ` [PATCH 3/7] mm: memcontrol: replace mem_cgroup_lruvec_online with mem_cgroup_online Vladimir Davydov
2015-12-11 19:25 ` Johannes Weiner
2015-12-10 11:39 ` [PATCH 4/7] swap.h: move memcg related stuff to the end of the file Vladimir Davydov
2015-12-11 19:25 ` Johannes Weiner
2015-12-10 11:39 ` [PATCH 5/7] mm: vmscan: do not scan anon pages if memcg swap limit is hit Vladimir Davydov
2015-12-11 19:27 ` Johannes Weiner
2015-12-10 11:39 ` [PATCH 6/7] mm: free swap cache aggressively if memcg swap is full Vladimir Davydov
2015-12-11 19:33 ` Johannes Weiner
2015-12-12 16:18 ` Vladimir Davydov
2015-12-10 11:39 ` [PATCH 7/7] Documentation: cgroup: add memory.swap.{current,max} description Vladimir Davydov
2015-12-11 19:42 ` Johannes Weiner [this message]
2015-12-12 16:19 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211194254.GF3773@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox