From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com [209.85.213.177]) by kanga.kvack.org (Postfix) with ESMTP id 2AD606B0038 for ; Wed, 9 Dec 2015 16:07:53 -0500 (EST) Received: by igbxm8 with SMTP id xm8so50865521igb.1 for ; Wed, 09 Dec 2015 13:07:53 -0800 (PST) Received: from smtprelay.hostedemail.com (smtprelay0231.hostedemail.com. [216.40.44.231]) by mx.google.com with ESMTPS id u29si15008743ioi.124.2015.12.09.13.07.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2015 13:07:52 -0800 (PST) Date: Wed, 9 Dec 2015 16:07:49 -0500 From: Steven Rostedt Subject: Re: [PATCH v4 3/7] x86: mm/gup: add gup trace points Message-ID: <20151209160749.250a2f56@gandalf.local.home> In-Reply-To: <1449682164-9933-4-git-send-email-yang.shi@linaro.org> References: <1449682164-9933-1-git-send-email-yang.shi@linaro.org> <1449682164-9933-4-git-send-email-yang.shi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Yang Shi Cc: akpm@linux-foundation.org, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linaro-kernel@lists.linaro.org, Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org On Wed, 9 Dec 2015 09:29:20 -0800 Yang Shi wrote: > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Signed-off-by: Yang Shi > --- > arch/x86/mm/gup.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/mm/gup.c b/arch/x86/mm/gup.c > index ae9a37b..a96bcb7 100644 > --- a/arch/x86/mm/gup.c > +++ b/arch/x86/mm/gup.c > @@ -12,6 +12,9 @@ > > #include > > +#define CREATE_TRACE_POINTS > +#include > First off, does the above even compile? Second, you already created the tracepoints in mm/gup.c, why are you creating them here again? CREATE_TRACE_POINTS must be defined only once per events/.h file. -- Steve > + > static inline pte_t gup_get_pte(pte_t *ptep) > { > #ifndef CONFIG_X86_PAE > @@ -270,6 +273,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write, > (void __user *)start, len))) > return 0; > > + trace_gup_get_user_pages_fast(start, nr_pages); > + > /* > * XXX: batch / limit 'nr', to avoid large irq off latency > * needs some instrumenting to determine the common sizes used by > @@ -373,6 +378,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, > } while (pgdp++, addr = next, addr != end); > local_irq_enable(); > > + trace_gup_get_user_pages_fast(start, nr_pages); > + > VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT); > return nr; > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org