From: Shaohua Li <shli@fb.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org, linux-api@vger.kernel.org,
Kernel-team@fb.com, Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH V3][for-next] mm: add a new vector based madvise syscall
Date: Tue, 8 Dec 2015 09:38:26 -0800 [thread overview]
Message-ID: <20151208173825.GA1351950@devbig084.prn1.facebook.com> (raw)
In-Reply-To: <20151208061807.GO15533@two.firstfloor.org>
On Tue, Dec 08, 2015 at 07:18:08AM +0100, Andi Kleen wrote:
> > + if (behavior != MADV_DONTNEED && behavior != MADV_FREE)
> > + return -EINVAL;
>
> This limitations is kind of lame and makes it a special purpose hack.
>
> It will also cause backwards compatibility issues if it needs
> to be extended later.
>
> How hard would it be to support all of madvise vectored?
>
> That would also give much cleaner documentation.
Ok, I'll add other behavior. Reducing syscall and mmap_sem locking is a
win for other madvise.
Thanks,
Shaohua
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-08 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 23:54 Shaohua Li
2015-12-08 6:18 ` Andi Kleen
2015-12-08 17:38 ` Shaohua Li [this message]
2015-12-08 21:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208173825.GA1351950@devbig084.prn1.facebook.com \
--to=shli@fb.com \
--cc=Kernel-team@fb.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox