From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>, Minchan Kim <minchan@kernel.org>
Subject: Re: [RFC 0/3] reduce latency of direct async compaction
Date: Tue, 8 Dec 2015 09:41:18 +0900 [thread overview]
Message-ID: <20151208004118.GA4325@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <20151207085956.GA16783@aaronlu.sh.intel.com>
On Mon, Dec 07, 2015 at 04:59:56PM +0800, Aaron Lu wrote:
> On Mon, Dec 07, 2015 at 04:35:24PM +0900, Joonsoo Kim wrote:
> > It looks like overhead still remain. I guess that migration scanner
> > would call pageblock_pfn_to_page() for more extended range so
> > overhead still remain.
> >
> > I have an idea to solve his problem. Aaron, could you test following patch
> > on top of base? It tries to skip calling pageblock_pfn_to_page()
>
> It doesn't apply on top of 25364a9e54fb8296837061bf684b76d20eec01fb
> cleanly, so I made some changes to make it apply and the result is:
> https://github.com/aaronlu/linux/commit/cb8d05829190b806ad3948ff9b9e08c8ba1daf63
Yes, that's okay. I made it on my working branch but it will not result in
any problem except applying.
>
> There is a problem occured right after the test starts:
> [ 58.080962] BUG: unable to handle kernel paging request at ffffea0082000018
> [ 58.089124] IP: [<ffffffff81193f29>] compaction_alloc+0xf9/0x270
> [ 58.096109] PGD 107ffd6067 PUD 207f7d5067 PMD 0
> [ 58.101569] Oops: 0000 [#1] SMP
I did some mistake. Please test following patch. It is also made
on my working branch so you need to resolve conflict but it would be
trivial.
I inserted some logs to check whether zone is contiguous or not.
Please check that normal zone is set to contiguous after testing.
Thanks.
------>8------
next prev parent reply other threads:[~2015-12-08 0:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 8:10 Vlastimil Babka
2015-12-03 8:10 ` [RFC 1/3] mm, compaction: reduce spurious pcplist drains Vlastimil Babka
2015-12-03 8:10 ` [RFC 2/3] mm, compaction: make async direct compaction skip blocks where isolation fails Vlastimil Babka
2015-12-03 8:10 ` [RFC 3/3] mm, compaction: direct freepage allocation for async direct compaction Vlastimil Babka
2015-12-03 9:25 ` [RFC 0/3] reduce latency of direct async compaction Aaron Lu
2015-12-03 9:38 ` Vlastimil Babka
2015-12-03 11:35 ` Aaron Lu
2015-12-03 11:52 ` Aaron Lu
2015-12-04 12:34 ` Vlastimil Babka
2015-12-07 7:35 ` Joonsoo Kim
2015-12-07 8:59 ` Aaron Lu
2015-12-08 0:41 ` Joonsoo Kim [this message]
2015-12-08 5:14 ` Aaron Lu
2015-12-08 6:51 ` Joonsoo Kim
2015-12-08 8:52 ` Aaron Lu
2015-12-09 0:33 ` Joonsoo Kim
2015-12-09 5:40 ` Aaron Lu
2015-12-10 4:35 ` Joonsoo Kim
2015-12-10 6:15 ` Aaron Lu
2015-12-04 6:25 ` Aaron Lu
2015-12-04 12:38 ` Vlastimil Babka
2015-12-07 3:14 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208004118.GA4325@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=aaron.lu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox