From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by kanga.kvack.org (Postfix) with ESMTP id A2D136B0038 for ; Mon, 30 Nov 2015 17:39:18 -0500 (EST) Received: by wmuu63 with SMTP id u63so149890538wmu.0 for ; Mon, 30 Nov 2015 14:39:18 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id gi3si69711631wjb.217.2015.11.30.14.39.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Nov 2015 14:39:17 -0800 (PST) Date: Mon, 30 Nov 2015 14:39:15 -0800 From: Andrew Morton Subject: Re: [linux-next:master 3174/3442] fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg' Message-Id: <20151130143915.50010329146ee04d92a26e49@linux-foundation.org> In-Reply-To: <201511261619.Q4kX5Hst%fengguang.wu@intel.com> References: <201511261619.Q4kX5Hst%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: kbuild test robot Cc: Ryan Ding , kbuild-all@01.org, Linux Memory Management List , Geert Uytterhoeven On Thu, 26 Nov 2015 16:45:21 +0800 kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 7dd2ecb6facfd1ac1a1cccc908e88e20e65e5801 > commit: 5d974dfe80b2322a6b0afc85beb15fe9bc233804 [3174/3442] ocfs2: fix ip_unaligned_aio deadlock with dio work queue > config: m68k-sun3_defconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 5d974dfe80b2322a6b0afc85beb15fe9bc233804 > # save the attached .config to linux build tree > make.cross ARCH=m68k > > All warnings (new ones prefixed by >>): > > In file included from arch/m68k/include/asm/atomic.h:6:0, > from include/linux/atomic.h:4, > from include/linux/spinlock.h:406, > from include/linux/wait.h:8, > from include/linux/fs.h:5, > from fs/ocfs2/file.c:27: > fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': > arch/m68k/include/asm/cmpxchg.h:78:22: warning: value computed is not used [-Wunused-value] > #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) > ^ > >> fs/ocfs2/file.c:2297:3: note: in expansion of macro 'xchg' > xchg(&iocb->ki_complete, saved_ki_complete); > ^ > > vim +/xchg +2297 fs/ocfs2/file.c > > 2281 written = ret; > 2282 > 2283 if (!ret) { > 2284 ret = jbd2_journal_force_commit(osb->journal->j_journal); > 2285 if (ret < 0) > 2286 written = ret; > 2287 } > 2288 > 2289 if (!ret) > 2290 ret = filemap_fdatawait_range(file->f_mapping, > 2291 iocb->ki_pos - written, > 2292 iocb->ki_pos - 1); > 2293 } > 2294 > 2295 out: > 2296 if (saved_ki_complete) > > 2297 xchg(&iocb->ki_complete, saved_ki_complete); > 2298 > 2299 if (rw_level != -1) > 2300 ocfs2_rw_unlock(inode, rw_level); > 2301 > 2302 out_mutex: > 2303 mutex_unlock(&inode->i_mutex); > 2304 > 2305 if (written) Beats me. Maybe a glitch in the m68k compiler? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org