linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: chenjie6@huawei.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	David.Woodhouse@intel.com, zhihui.gao@huawei.com,
	lizefan@huawei.com, stable@vger.kernel.org
Subject: Re: [PATCH] bugfix oom kill init lead panic
Date: Sun, 29 Nov 2015 19:08:02 -0800	[thread overview]
Message-ID: <20151129190802.dc66cf35.akpm@linux-foundation.org> (raw)
In-Reply-To: <1448880869-20506-1-git-send-email-chenjie6@huawei.com>

On Mon, 30 Nov 2015 18:54:29 +0800 <chenjie6@huawei.com> wrote:

> From: chenjie <chenjie6@huawei.com>
> 
> when oom happened we can see:
> Out of memory: Kill process 9134 (init) score 3 or sacrifice child                  
> Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
> Kill process 1 (init) sharing same memory
> ...
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009
> 
> That's because:
> 	the busybox init will vfork a process,oom_kill_process found
> the init not the children,their mm is the same when vfork.
> 
> ...
>
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -513,7 +513,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
>  	rcu_read_lock();
>  	for_each_process(p)
>  		if (p->mm == mm && !same_thread_group(p, victim) &&
> -		    !(p->flags & PF_KTHREAD)) {
> +		    !(p->flags & PF_KTHREAD) && !is_global_init(p)) {
>  			if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>  				continue;

What kernel version are you using?

I don't think this can happen in current code...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-11-30  3:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 10:54 chenjie6
2015-11-30  3:08 ` Andrew Morton [this message]
2015-11-30  3:27   ` Chenjie (K)
2015-11-30 22:08     ` David Rientjes
2015-12-01  4:15       ` Chenjie (K)
2015-12-01  6:09         ` Chenjie (K)
2015-12-01 23:41 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151129190802.dc66cf35.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=David.Woodhouse@intel.com \
    --cc=chenjie6@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=stable@vger.kernel.org \
    --cc=zhihui.gao@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox