From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f175.google.com (mail-yk0-f175.google.com [209.85.160.175]) by kanga.kvack.org (Postfix) with ESMTP id 61D7F6B026B for ; Wed, 18 Nov 2015 03:39:53 -0500 (EST) Received: by ykba77 with SMTP id a77so51637215ykb.2 for ; Wed, 18 Nov 2015 00:39:52 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id k200si1755527ywe.163.2015.11.18.00.39.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2015 00:39:52 -0800 (PST) Date: Wed, 18 Nov 2015 09:39:45 +0100 From: Jesper Dangaard Brouer Subject: Re: [PATCH] fault-inject: correct printk order for interval vs. probability Message-ID: <20151118093945.4bbd6bd7@redhat.com> In-Reply-To: <20151117114750.12395.53387.stgit@firesoul> References: <20151117114750.12395.53387.stgit@firesoul> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: akinobu.mita@gmail.com, linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , dmonakhov@openvz.org, brouer@redhat.com, Florian Westphal Disregard this patch... Florian already fixed it in: bb387002693e ("fault-inject: fix inverted interval/probability values in printk") $ git describe --contains bb387002693e v4.3-rc7~11^2~1 On Tue, 17 Nov 2015 12:48:37 +0100 Jesper Dangaard Brouer wrote: > In function fail_dump() printk output of the attributes interval and > probability got swapped. This was introduced in commit > 6adc4a22f20b ("fault-inject: add ratelimit option"). > > Fixes: 6adc4a22f20b ("fault-inject: add ratelimit option") > Signed-off-by: Jesper Dangaard Brouer > > --- > Don't know who is maintainer for lib/, hope someone will > pick this up... > > lib/fault-inject.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/fault-inject.c b/lib/fault-inject.c > index f1cdeb024d17..6a823a53e357 100644 > --- a/lib/fault-inject.c > +++ b/lib/fault-inject.c > @@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr) > printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n" > "name %pd, interval %lu, probability %lu, " > "space %d, times %d\n", attr->dname, > - attr->probability, attr->interval, > + attr->interval, attr->probability, > atomic_read(&attr->space), > atomic_read(&attr->times)); > if (attr->verbose > 1) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org