[PATCH] fault-inject: correct printk order for interval vs. probability

[PATCH] fault-inject: correct printk order for interval vs. probability

[Jesper Dangaard Brouer]

In function fail_dump() printk output of the attributes interval and
probability got swapped.  This was introduced in commit
6adc4a22f20b ("fault-inject: add ratelimit option").

Fixes: 6adc4a22f20b ("fault-inject: add ratelimit option")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>

---
Don't know who is maintainer for lib/, hope someone will
pick this up...

 lib/fault-inject.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fault-inject.c b/lib/fault-inject.c
index f1cdeb024d17..6a823a53e357 100644
--- a/lib/fault-inject.c
+++ b/lib/fault-inject.c
@@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
 		printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
 		       "name %pd, interval %lu, probability %lu, "
 		       "space %d, times %d\n", attr->dname,
-		       attr->probability, attr->interval,
+		       attr->interval, attr->probability,
 		       atomic_read(&attr->space),
 		       atomic_read(&attr->times));
 		if (attr->verbose > 1)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] fault-inject: correct printk order for interval vs. probability

[Jesper Dangaard Brouer]

Disregard this patch... Florian already fixed it in:

 bb387002693e ("fault-inject: fix inverted interval/probability values in printk")

$ git describe --contains bb387002693e
v4.3-rc7~11^2~1


On Tue, 17 Nov 2015 12:48:37 +0100
Jesper Dangaard Brouer <brouer@redhat.com> wrote:

> In function fail_dump() printk output of the attributes interval and
> probability got swapped.  This was introduced in commit
> 6adc4a22f20b ("fault-inject: add ratelimit option").
> 
> Fixes: 6adc4a22f20b ("fault-inject: add ratelimit option")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> 
> ---
> Don't know who is maintainer for lib/, hope someone will
> pick this up...
> 
>  lib/fault-inject.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index f1cdeb024d17..6a823a53e357 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -44,7 +44,7 @@ static void fail_dump(struct fault_attr *attr)
>  		printk(KERN_NOTICE "FAULT_INJECTION: forcing a failure.\n"
>  		       "name %pd, interval %lu, probability %lu, "
>  		       "space %d, times %d\n", attr->dname,
> -		       attr->probability, attr->interval,
> +		       attr->interval, attr->probability,
>  		       atomic_read(&attr->space),
>  		       atomic_read(&attr->times));
>  		if (attr->verbose > 1)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>