From: Mel Gorman <mgorman@suse.de>
To: mhocko@kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/2] mm: get rid of __alloc_pages_high_priority
Date: Mon, 16 Nov 2015 18:43:04 +0000 [thread overview]
Message-ID: <20151116173754.GG19677@suse.de> (raw)
In-Reply-To: <1447680139-16484-2-git-send-email-mhocko@kernel.org>
On Mon, Nov 16, 2015 at 02:22:18PM +0100, mhocko@kernel.org wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> __alloc_pages_high_priority doesn't do anything special other than it
> calls get_page_from_freelist and loops around GFP_NOFAIL allocation
> until it succeeds. It would be better if the first part was done in
> __alloc_pages_slowpath where we modify the zonelist because this would
> be easier to read and understand. Opencoding the function into its only
> caller allows to simplify it a bit as well.
>
> This patch doesn't introduce any functional changes.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-16 18:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 13:22 [PATCH 0/2] " mhocko
2015-11-16 13:22 ` [PATCH 1/2] mm: " mhocko
2015-11-16 18:43 ` Mel Gorman [this message]
2015-11-16 21:14 ` David Rientjes
2015-11-18 14:48 ` Vlastimil Babka
2015-11-16 13:22 ` [PATCH 2/2] mm: do not loop over ALLOC_NO_WATERMARKS without triggering reclaim mhocko
2015-11-16 21:18 ` David Rientjes
2015-11-17 10:58 ` Tetsuo Handa
2015-11-18 9:11 ` Michal Hocko
2015-11-18 9:22 ` Michal Hocko
2015-11-18 14:57 ` Vlastimil Babka
2015-11-18 15:11 ` Michal Hocko
2015-11-18 15:19 ` Vlastimil Babka
2015-11-23 9:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116173754.GG19677@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox