From: Michal Hocko <mhocko@kernel.org>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com,
dan.j.williams@intel.com, dave.hansen@linux.intel.com,
dave@stgolabs.net, dhowells@redhat.com,
dingel@linux.vnet.ibm.com, hannes@cmpxchg.org,
hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com,
joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de,
mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com,
penberg@kernel.org, rientjes@google.com, sasha.levin@oracle.com,
tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz,
vdavydov@parallels.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] mm/mmzone: refactor memmap_valid_within
Date: Mon, 16 Nov 2015 13:45:01 +0100 [thread overview]
Message-ID: <20151116124501.GF14116@dhcp22.suse.cz> (raw)
In-Reply-To: <1447656686-4851-8-git-send-email-baiyaowei@cmss.chinamobile.com>
On Mon 16-11-15 14:51:26, Yaowei Bai wrote:
[...]
> @@ -72,16 +72,10 @@ struct zoneref *next_zones_zonelist(struct zoneref *z,
> }
>
> #ifdef CONFIG_ARCH_HAS_HOLES_MEMORYMODEL
> -int memmap_valid_within(unsigned long pfn,
> +bool memmap_valid_within(unsigned long pfn,
> struct page *page, struct zone *zone)
> {
> - if (page_to_pfn(page) != pfn)
> - return 0;
> -
> - if (page_zone(page) != zone)
> - return 0;
> -
> - return 1;
> + return page_to_pfn(page) == pfn && page_zone(page) == zone;
I do not think this is easier to read. Quite contrary
> }
> #endif /* CONFIG_ARCH_HAS_HOLES_MEMORYMODEL */
>
> --
> 1.9.1
>
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-16 12:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 6:51 [PATCH 0/7] some small improvement Yaowei Bai
2015-11-16 6:51 ` [PATCH 1/7] ipc/shm: is_file_shm_hugepages can be boolean Yaowei Bai
2015-11-16 12:39 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 2/7] mm/hugetlb: is_file_hugepages " Yaowei Bai
2015-11-16 12:40 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 3/7] mm/memblock: memblock_is_memory/reserved " Yaowei Bai
2015-11-16 12:41 ` Michal Hocko
2015-11-16 6:51 ` [PATCH 4/7] mm/vmscan: page_is_file_cache " Yaowei Bai
2015-11-16 10:10 ` David Rientjes
2015-11-17 2:18 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 5/7] mm/lru: remove unused is_unevictable_lru function Yaowei Bai
2015-11-16 12:43 ` Michal Hocko
2015-11-17 5:16 ` Hillf Danton
2015-11-16 6:51 ` [PATCH 6/7] mm/gfp: make gfp_zonelist return directly and bool Yaowei Bai
2015-11-16 10:05 ` David Rientjes
2015-11-17 1:59 ` Yaowei Bai
2015-11-17 5:44 ` David Rientjes
2015-11-17 8:29 ` Yaowei Bai
2015-11-16 6:51 ` [PATCH 7/7] mm/mmzone: refactor memmap_valid_within Yaowei Bai
2015-11-16 12:45 ` Michal Hocko [this message]
2015-11-17 2:40 ` Yaowei Bai
2015-11-17 9:02 ` [PATCH] mm/zonelist: enumerate zonelists array index Yaowei Bai
2015-11-18 1:38 ` [PATCH] mm/mmzone: memmap_valid_within can be boolean Yaowei Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116124501.GF14116@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=dhowells@redhat.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=holt@sgi.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox