linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: htejun@gmail.com, cl@linux.com, mhocko@suse.com,
	linux-mm@kvack.org, xfs@oss.sgi.com
Subject: Re: memory reclaim problems on fs usage
Date: Sun, 15 Nov 2015 12:29:23 +0100	[thread overview]
Message-ID: <201511151229.23312.arekm@maven.pl> (raw)
In-Reply-To: <201511151135.JGD81717.OFOOSMFJFQHVtL@I-love.SAKURA.ne.jp>

On Sunday 15 of November 2015, Tetsuo Handa wrote:
> Arkadiusz Miskiewicz wrote:
> > > > vmstat_update() and submit_flushes() remained pending for about 110
> > > > seconds. If xlog_cil_push_work() were spinning inside GFP_NOFS
> > > > allocation, it should be reported as MemAlloc: traces, but no such
> > > > lines are recorded. I don't know why xlog_cil_push_work() did not
> > > > call schedule() for so long. Anyway, applying
> > > > http://lkml.kernel.org/r/20151111160336.GD1432@dhcp22.suse.cz should
> > > > solve vmstat_update() part.
> > > 
> > > To apply that patch on top of 4.1.13 I also had to apply patches listed
> > > below.
> > > 
> > > So in summary appllied:
> > > http://sprunge.us/GYBb
> > > http://sprunge.us/XWUX
> > > http://sprunge.us/jZjV
> > 
> > I've tried more to trigger "page allocation failure" with usual actions
> > that triggered it previously but couldn't reproduce. With these patches
> > applied it doesn't happen.
> > 
> > Logs from my tests:
> > 
> > http://ixion.pld-linux.org/~arekm/log-mm-3.txt.gz
> > http://ixion.pld-linux.org/~arekm/log-mm-4.txt.gz (with swap added)
> 
> Good.
> 
> vmstat_update() and submit_flushes() are no longer pending for long.
> 
> log-mm-4.txt:Nov 14 16:40:08 srv kernel: [167753.393960]     pending:
> vmstat_shepherd, vmpressure_work_fn log-mm-4.txt:Nov 14 16:40:08 srv
> kernel: [167753.393984]     pending: submit_flushes [md_mod]
> log-mm-4.txt:Nov 14 16:41:08 srv kernel: [167813.439405]     pending:
> submit_flushes [md_mod] log-mm-4.txt:Nov 14 17:17:19 srv kernel:
> [169985.104806]     pending: vmstat_shepherd
> 
> I think that the vmstat statistics now have correct values.
> 
> > But are these patches solving the problem or just hiding it?
> 
> Excuse me but I can't judge.
>
> If you are interested in monitoring how vmstat statistics are changing
> under stalled condition, you can try below patch.


Here is log with this and all previous patches applied:
http://ixion.pld-linux.org/~arekm/log-mm-5.txt.gz


> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 35a46b4..3de3a14 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2794,8 +2794,7 @@ static int kmallocwd(void *unused)
>  	rcu_read_unlock();
>  	preempt_enable();
>  	show_workqueue_state();
> -	if (dump_target_pid <= 0)
> -		dump_target_pid = -pid;
> +	show_mem(0);
>  	/* Wait until next timeout duration. */
>  	schedule_timeout_interruptible(kmallocwd_timeout);
>  	if (memalloc_counter[index])


-- 
Arkadiusz Miśkiewicz, arekm / ( maven.pl | pld-linux.org )

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-11-15 11:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 22:13 Arkadiusz Miśkiewicz
2015-11-11 15:58 ` Tetsuo Handa
2015-11-11 16:19   ` Arkadiusz Miśkiewicz
2015-11-11 22:19     ` Tetsuo Handa
2015-11-12  6:06       ` Arkadiusz Miśkiewicz
2015-11-12 14:12         ` Tetsuo Handa
2015-11-12 20:06           ` Dave Chinner
2015-11-13 12:19             ` Tetsuo Handa
2015-11-12 21:28           ` Arkadiusz Miśkiewicz
2015-11-14 20:40             ` Arkadiusz Miśkiewicz
2015-11-15  2:35               ` Tetsuo Handa
2015-11-15 11:29                 ` Arkadiusz Miśkiewicz [this message]
2015-11-15 14:13                   ` Tetsuo Handa
2015-11-15 14:49                     ` Arkadiusz Miśkiewicz
2015-11-16 16:15                       ` Michal Hocko
2015-11-18 22:36                         ` Arkadiusz Miśkiewicz
2015-11-19 15:59                           ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201511151229.23312.arekm@maven.pl \
    --to=arekm@maven.pl \
    --cc=cl@linux.com \
    --cc=htejun@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox