Re: [PATCH] slub: add missing kmem cgroup support to kmem_cache_free_bulk

[Joonsoo Kim <iamjoonsoo.kim@lge.com>]

On Thu, Oct 29, 2015 at 02:05:31PM +0100, Jesper Dangaard Brouer wrote:
> Initial implementation missed support for kmem cgroup support
> in kmem_cache_free_bulk() call, add this.
> 
> If CONFIG_MEMCG_KMEM is not enabled, the compiler should
> be smart enough to not add any asm code.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
>  mm/slub.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 9be12ffae9fc..9875864ad7b8 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2845,6 +2845,9 @@ static int build_detached_freelist(struct kmem_cache *s, size_t size,
>  	if (!object)
>  		return 0;
>  
> +	/* Support for kmemcg */
> +	s = cache_from_obj(s, object);
> +
>  	/* Start new detached freelist */
>  	set_freepointer(s, object, NULL);
>  	df->page = virt_to_head_page(object);

Hello,

It'd better to add this 's = cache_from_obj()' on kmem_cache_free_bulk().
Not only build_detached_freelist() but also slab_free() need proper
cache.

Thanks

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>