[linux-review:Tetsuo-Handa/mm-vmscan-Use-accurate-values-for-zone_reclaimable-checks/20151021-203036 9356/9695] mm/hugetlb.c:1583:13: sparse: symbol '__alloc_buddy_huge_page_no_mpol' was not declared. Should it be static?

[linux-review:Tetsuo-Handa/mm-vmscan-Use-accurate-values-for-zone_reclaimable-checks/20151021-203036 9356/9695] mm/hugetlb.c:1583:13: sparse: symbol '__alloc_buddy_huge_page_no_mpol' was not declared. Should it be static?

[kbuild test robot]

Hi Dave,

[auto build test WARNING on v4.3-rc6-108-gce1fad2 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Tetsuo-Handa/mm-vmscan-Use-accurate-values-for-zone_reclaimable-checks/20151021-203036
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> mm/hugetlb.c:1583:13: sparse: symbol '__alloc_buddy_huge_page_no_mpol' was not declared. Should it be static?
>> mm/hugetlb.c:1593:13: sparse: symbol '__alloc_buddy_huge_page_with_mpol' was not declared. Should it be static?
   mm/hugetlb.c:1642:20: sparse: context imbalance in 'gather_surplus_pages' - unexpected unlock
   mm/hugetlb.c:3361:9: sparse: context imbalance in 'hugetlb_cow' - unexpected unlock
   mm/hugetlb.c:3905:25: sparse: context imbalance in 'follow_hugetlb_page' - different lock contexts for basic block

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

[RFC PATCH] mm, hugetlb: __alloc_buddy_huge_page_no_mpol() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 hugetlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index c57d671..e1248f9 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1580,7 +1580,7 @@ static struct page *__alloc_buddy_huge_page(struct hstate *h,
  * NUMA_NO_NODE, which means that it may be allocated
  * anywhere.
  */
-struct page *__alloc_buddy_huge_page_no_mpol(struct hstate *h, int nid)
+static struct page *__alloc_buddy_huge_page_no_mpol(struct hstate *h, int nid)
 {
 	unsigned long addr = -1;
 
@@ -1590,7 +1590,7 @@ struct page *__alloc_buddy_huge_page_no_mpol(struct hstate *h, int nid)
 /*
  * Use the VMA's mpolicy to allocate a huge page from the buddy.
  */
-struct page *__alloc_buddy_huge_page_with_mpol(struct hstate *h,
+static struct page *__alloc_buddy_huge_page_with_mpol(struct hstate *h,
 		struct vm_area_struct *vma, unsigned long addr)
 {
 	return __alloc_buddy_huge_page(h, vma, addr, NUMA_NO_NODE);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>