* [PATCH mmotm] mm: dont split thp page when syscall is called fix 4
@ 2015-10-16 22:46 Hugh Dickins
2015-10-19 6:33 ` Minchan Kim
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2015-10-16 22:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Minchan Kim, Kirill A. Shutemov, linux-kernel, linux-mm
Compiler gives helpful warnings that madvise_free_pte_range()
has the args to split_huge_pmd() the wrong way round.
Signed-off-by: Hugh Dickins <hughd@google.com>
--- mmotm/mm/madvise.c 2015-10-15 15:26:59.839572171 -0700
+++ linux/mm/madvise.c 2015-10-16 11:59:10.144527813 -0700
@@ -283,7 +283,7 @@ static int madvise_free_pte_range(pmd_t
next = pmd_addr_end(addr, end);
if (pmd_trans_huge(*pmd)) {
if (next - addr != HPAGE_PMD_SIZE)
- split_huge_pmd(vma, addr, pmd);
+ split_huge_pmd(vma, pmd, addr);
else if (!madvise_free_huge_pmd(tlb, vma, pmd, addr))
goto next;
/* fall through */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH mmotm] mm: dont split thp page when syscall is called fix 4
2015-10-16 22:46 [PATCH mmotm] mm: dont split thp page when syscall is called fix 4 Hugh Dickins
@ 2015-10-19 6:33 ` Minchan Kim
0 siblings, 0 replies; 2+ messages in thread
From: Minchan Kim @ 2015-10-19 6:33 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Andrew Morton, Kirill A. Shutemov, linux-kernel, linux-mm
Hello Hugh,
On Fri, Oct 16, 2015 at 03:46:03PM -0700, Hugh Dickins wrote:
> Compiler gives helpful warnings that madvise_free_pte_range()
> has the args to split_huge_pmd() the wrong way round.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Thanks for catching my mistake.
Reviewed-by: Minchan Kim <minchan@kernel.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-19 6:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-16 22:46 [PATCH mmotm] mm: dont split thp page when syscall is called fix 4 Hugh Dickins
2015-10-19 6:33 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox