From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by kanga.kvack.org (Postfix) with ESMTP id D2E2C6B0253 for ; Tue, 13 Oct 2015 03:59:54 -0400 (EDT) Received: by pabve7 with SMTP id ve7so14141142pab.2 for ; Tue, 13 Oct 2015 00:59:54 -0700 (PDT) Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com. [2607:f8b0:400e:c03::22c]) by mx.google.com with ESMTPS id j5si3261498pbq.128.2015.10.13.00.59.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2015 00:59:54 -0700 (PDT) Received: by padhy16 with SMTP id hy16so13955514pad.1 for ; Tue, 13 Oct 2015 00:59:54 -0700 (PDT) Date: Tue, 13 Oct 2015 17:00:44 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH] zsmalloc: remove unless line in obj_free Message-ID: <20151013080044.GA587@swordfish> References: <1444717862-27234-1-git-send-email-zhuhui@xiaomi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444717862-27234-1-git-send-email-zhuhui@xiaomi.com> Sender: owner-linux-mm@kvack.org List-ID: To: Hui Zhu Cc: Minchan Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, teawater@gmail.com, Sergey Senozhatsky On (10/13/15 14:31), Hui Zhu wrote: > Signed-off-by: Hui Zhu s/unless/useless/ other than that Reviewed-by: Sergey Senozhatsky -ss > --- > mm/zsmalloc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index f135b1b..c7338f0 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, > struct page *first_page, *f_page; > unsigned long f_objidx, f_offset; > void *vaddr; > - int class_idx; > - enum fullness_group fullness; > > BUG_ON(!obj); > > @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, > obj_to_location(obj, &f_page, &f_objidx); > first_page = get_first_page(f_page); > > - get_zspage_mapping(first_page, &class_idx, &fullness); > f_offset = obj_idx_to_offset(f_page, f_objidx, class->size); > > vaddr = kmap_atomic(f_page); > -- > 1.9.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org