From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by kanga.kvack.org (Postfix) with ESMTP id 2E222440313 for ; Sun, 4 Oct 2015 22:30:41 -0400 (EDT) Received: by pacfv12 with SMTP id fv12so164510320pac.2 for ; Sun, 04 Oct 2015 19:30:40 -0700 (PDT) Received: from m50-135.163.com (m50-135.163.com. [123.125.50.135]) by mx.google.com with ESMTP id j6si36489617pbq.56.2015.10.04.19.30.39 for ; Sun, 04 Oct 2015 19:30:40 -0700 (PDT) Date: Mon, 5 Oct 2015 10:30:00 +0800 From: Geliang Tang Subject: Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON() Message-ID: <20151005023000.GA1607@bogon> References: <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com> <20151005015055.GA8831@linux-uzut.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151005015055.GA8831@linux-uzut.site> Sender: owner-linux-mm@kvack.org List-ID: To: Davidlohr Bueso Cc: Andrew Morton , "Kirill A. Shutemov" , Hugh Dickins , "Peter Zij lstra (Intel)" , Andrea Arcangeli , Joonsoo Kim , Arnd Bergmann , Paul Gortmaker , Leon Romanovsky , Oleg Nesterov , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Sun, Oct 04, 2015 at 06:50:55PM -0700, Davidlohr Bueso wrote: > On Sun, 04 Oct 2015, Geliang Tang wrote: > > >BUG_ON() already contain an unlikely compiler flag. Drop it. > > > >Signed-off-by: Geliang Tang > > Acked-by: Davidlohr Bueso > > ... but I believe you do have some left: > > drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > ivecs)); > drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q))); > kernel/sched/core.c: BUG_ON(unlikely(task_stack_end_corrupted(prev))); Thanks for your review, the left have been sended out already in two other patches. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org