From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by kanga.kvack.org (Postfix) with ESMTP id CE931440313 for ; Sun, 4 Oct 2015 22:04:22 -0400 (EDT) Received: by wicfx3 with SMTP id fx3so94223779wic.0 for ; Sun, 04 Oct 2015 19:04:22 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id he6si28099983wjc.75.2015.10.04.19.04.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 04 Oct 2015 19:04:21 -0700 (PDT) Date: Sun, 4 Oct 2015 19:04:06 -0700 From: Davidlohr Bueso Subject: Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON() Message-ID: <20151005020406.GB8831@linux-uzut.site> References: <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Leon Romanovsky Cc: Geliang Tang , Andrew Morton , "Kirill A. Shutemov" , Hugh Dickins , "Peter Zijlstra (Intel)" , Andrea Arcangeli , Joonsoo Kim , Arnd Bergmann , Paul Gortmaker , Oleg Nesterov , Linux-MM , "linux-kernel@vger.kernel.org" On Sun, 04 Oct 2015, Leon Romanovsky wrote: >On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang wrote: >> BUG_ON() already contain an unlikely compiler flag. Drop it. >It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not set. Yeah, but that's like the 1% of the cases -- and those probably don't even care about the branch prediction (I could be wrong). So overall I like getting rid of explicit BUG_ON(unlikely(... calls. In fact there's a _reason_ why there are so few of them in the kernel. Thanks, Davidlohr -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org