* [PATCH] mm/slub: calculate start order with reserved in consideration
@ 2015-09-30 2:30 Wei Yang
2015-09-30 13:53 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yang @ 2015-09-30 2:30 UTC (permalink / raw)
To: cl, penberg, rientjes; +Cc: linux-mm, Wei Yang
In function slub_order(), the order starts from max(min_order,
get_order(min_objects * size)). When (min_objects * size) has different
order with (min_objects * size + reserved), it will skip this order by the
check in the loop.
This patch optimizes this a little by calculating the start order with
reserved in consideration and remove the check in loop.
Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
This patch is based on the previous one "mm/slub: use get_order() instead of
fls()", so may not apply on current tree.
---
mm/slub.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index e309ed1..e1bb147 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2912,19 +2912,15 @@ static inline int slab_order(int size, int min_objects,
if (order_objects(min_order, size, reserved) > MAX_OBJS_PER_PAGE)
return get_order(size * MAX_OBJS_PER_PAGE) - 1;
- for (order = max(min_order, get_order(min_objects * size));
+ for (order = max(min_order, get_order(min_objects * size + reserved));
order <= max_order; order++) {
unsigned long slab_size = PAGE_SIZE << order;
- if (slab_size < min_objects * size + reserved)
- continue;
-
rem = (slab_size - reserved) % size;
if (rem <= slab_size / fract_leftover)
break;
-
}
return order;
--
2.5.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/slub: calculate start order with reserved in consideration
2015-09-30 2:30 [PATCH] mm/slub: calculate start order with reserved in consideration Wei Yang
@ 2015-09-30 13:53 ` Christoph Lameter
2015-09-30 23:43 ` Wei Yang
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2015-09-30 13:53 UTC (permalink / raw)
To: Wei Yang; +Cc: penberg, rientjes, linux-mm
On Wed, 30 Sep 2015, Wei Yang wrote:
> In function slub_order(), the order starts from max(min_order,
> get_order(min_objects * size)). When (min_objects * size) has different
> order with (min_objects * size + reserved), it will skip this order by the
> check in the loop.
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/slub: calculate start order with reserved in consideration
2015-09-30 13:53 ` Christoph Lameter
@ 2015-09-30 23:43 ` Wei Yang
0 siblings, 0 replies; 3+ messages in thread
From: Wei Yang @ 2015-09-30 23:43 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Wei Yang, penberg, rientjes, linux-mm
On Wed, Sep 30, 2015 at 08:53:03AM -0500, Christoph Lameter wrote:
>On Wed, 30 Sep 2015, Wei Yang wrote:
>
>> In function slub_order(), the order starts from max(min_order,
>> get_order(min_objects * size)). When (min_objects * size) has different
>> order with (min_objects * size + reserved), it will skip this order by the
>> check in the loop.
>
>Acked-by: Christoph Lameter <cl@linux.com>
Christoph,
Glad to see your Ack.
Thanks :-)
BTW, do you have any comment for this patch "mm/slub: correct the comment in
calculate_order()"? I hope my understanding is correct.
--
Richard Yang
Help you, Help me
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-30 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-30 2:30 [PATCH] mm/slub: calculate start order with reserved in consideration Wei Yang
2015-09-30 13:53 ` Christoph Lameter
2015-09-30 23:43 ` Wei Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox