From: Andrew Morton <akpm@linux-foundation.org>
To: Alexandru Moise <00moses.alexander00@gmail.com>
Cc: mgorman@suse.de, vbabka@suse.cz, mhocko@suse.com,
js1304@gmail.com, hannes@cmpxchg.org,
alexander.h.duyck@redhat.com, sasha.levin@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache_reclaimable
Date: Tue, 29 Sep 2015 22:28:57 -0700 [thread overview]
Message-ID: <20150929222857.9f29351f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20150930051004.GA13409@gmail.com>
On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@gmail.com> wrote:
> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> > >
> > > static unsigned long zone_reclaimable_pages(struct zone *zone)
> > > {
> > > - int nr;
> > > + unsigned long nr;
> > >
> > > nr = zone_page_state(zone, NR_ACTIVE_FILE) +
> > > zone_page_state(zone, NR_INACTIVE_FILE);
> >
> > OK.
> >
>
> Are you sure? Mel Gorman raised the following issue on patch 1/2:
>
> https://lkml.org/lkml/2015/9/29/253
__zone_watermark_ok() is very different from zone_reclaimable_pages().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-30 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 21:04 Alexandru Moise
2015-09-29 23:07 ` Andrew Morton
2015-09-30 5:10 ` Alexandru Moise
2015-09-30 5:28 ` Andrew Morton [this message]
2015-09-30 5:33 ` Alexandru Moise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929222857.9f29351f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=00moses.alexander00@gmail.com \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox