From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by kanga.kvack.org (Postfix) with ESMTP id 9C01C6B0257 for ; Fri, 25 Sep 2015 09:29:10 -0400 (EDT) Received: by wicfx3 with SMTP id fx3so21948803wic.1 for ; Fri, 25 Sep 2015 06:29:10 -0700 (PDT) Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com. [209.85.212.180]) by mx.google.com with ESMTPS id tc5si4703970wic.21.2015.09.25.06.29.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Sep 2015 06:29:09 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so21948235wic.1 for ; Fri, 25 Sep 2015 06:29:09 -0700 (PDT) Date: Fri, 25 Sep 2015 15:29:07 +0200 From: Michal Hocko Subject: Re: [PATCH v3 4/4] mm, procfs: Display VmAnon, VmFile and VmShm in /proc/pid/status Message-ID: <20150925132907.GK16497@dhcp22.suse.cz> References: <1438779685-5227-1-git-send-email-vbabka@suse.cz> <1438779685-5227-5-git-send-email-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438779685-5227-5-git-send-email-vbabka@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Andrew Morton , Jerome Marchand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , "Kirill A. Shutemov" , Cyrill Gorcunov , Randy Dunlap , linux-s390@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Peter Zijlstra , Paul Mackerras , Arnaldo Carvalho de Melo , Oleg Nesterov , Linux API , Konstantin Khlebnikov , Minchan Kim On Wed 05-08-15 15:01:25, Vlastimil Babka wrote: > From: Jerome Marchand > > It's currently inconvenient to retrieve MM_ANONPAGES value from status > and statm files and there is no way to separate MM_FILEPAGES and > MM_SHMEMPAGES. Add VmAnon, VmFile and VmShm lines in /proc//status > to solve these issues. Yes this is definitely an improvement. I have no strong opinion on naming. VmFOO is consistent with the rest (e.g. VmData, Stk...) > > Signed-off-by: Jerome Marchand > Signed-off-by: Vlastimil Babka Acked-by: Michal Hocko [...] > @@ -82,7 +91,7 @@ unsigned long task_statm(struct mm_struct *mm, > unsigned long *data, unsigned long *resident) > { > *shared = get_mm_counter(mm, MM_FILEPAGES) + > - get_mm_counter(mm, MM_SHMEMPAGES); > + get_mm_counter_shmem(mm); > *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) > >> PAGE_SHIFT; > *data = mm->total_vm - mm->shared_vm; Ahh, so you have fixed up the compilation issue from previous patch here... This really belong to the previous patch as already noted. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org