From: Johannes Weiner <hannes@cmpxchg.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Michal Hocko <mhocko@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol: fix order calculation in try_charge()
Date: Fri, 18 Sep 2015 09:42:17 +0200 [thread overview]
Message-ID: <20150918074217.GD15395@cmpxchg.org> (raw)
In-Reply-To: <1442318757-7141-1-git-send-email-jmarchan@redhat.com>
On Tue, Sep 15, 2015 at 02:05:57PM +0200, Jerome Marchand wrote:
> Since commit <6539cc05386> (mm: memcontrol: fold mem_cgroup_do_charge()),
> the order to pass to mem_cgroup_oom() is calculated by passing the number
> of pages to get_order() instead of the expected size in bytes. AFAICT,
> it only affects the value displayed in the oom warning message.
> This patch fix this.
>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Thanks, Jerome. One minor thing:
> @@ -2032,7 +2032,8 @@ retry:
>
> mem_cgroup_events(mem_over_limit, MEMCG_OOM, 1);
>
> - mem_cgroup_oom(mem_over_limit, gfp_mask, get_order(nr_pages));
> + mem_cgroup_oom(mem_over_limit, gfp_mask,
> + get_order(nr_pages * PAGE_SIZE));
fls(nr_pages)?
get_order() is basically fls(x / PAGE_SIZE).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-09-18 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 12:05 Jerome Marchand
2015-09-15 13:56 ` Michal Hocko
2015-09-17 13:04 ` Michal Hocko
2015-09-18 7:42 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918074217.GD15395@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=cgroups@vger.kernel.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox